feat: add configurable maxBuffer option to runDiffImageToSnapshot #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need updates to readme |
haze
force-pushed
the
hb/configurable-max-diff-buffer
branch
from
6371fef to
f10d37d
Compare
dogpatch626
approved these changes
Dec 11, 2023
JAdshead
approved these changes
Dec 11, 2023
oneamexbot
added a commit
that referenced
this pull request
Dec 11, 2023
# [6.4.0](v6.3.0...v6.4.0) (2023-12-11) ### Features * add configurable maxBuffer option to runDiffImageToSnapshot ([#344](#344)) ([befad8b](befad8b))
|
🎉 This PR is included in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new option
maxChildProcessBufferSizeInBytes. This lets us override the maximum allowed byte count for stderr/stdout fordiff-screenshotchild processes.Motivation and Context
One of my projects routinely diffs large (>4k) images. The default
10 MBlimit is too small for my use case.How Has This Been Tested?
Privately tested in a fork before upstreaming changes; Configuration change means we no longer run into the default limit. Updated tests.
Types of Changes
Checklist:
What is the Impact to Developers Using Jest-Image-Snapshot?
There should be no discernible impact beyond additional configurability.