Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff performance regression #87

Closed
ProTip opened this issue Jun 30, 2018 · 5 comments
Closed

Diff performance regression #87

ProTip opened this issue Jun 30, 2018 · 5 comments

Comments

@ProTip
Copy link

ProTip commented Jun 30, 2018 •
edited
Loading

I'm seeing ~2.5s on an toMatchImageSnapshot when the images differ in 2.4.0 on node 9. I'm seeing about ~4.7s+ on 2.4.3.

As a side note, for me it takes about 1s+ longer with node 8 vs 9 on 2.4.0.

All of these timings, even the better timings, seem simply incredible for diffing and writing images. I'm guessing this is largely due to some slowness in pngjs?
@anescobar1991
Copy link
Member

Can you push up a repro for us to investigate? You are right that is crazy slow.

@ProTip
Copy link
Author

ProTip commented Jul 1, 2018

I believe I have a fix on the way.

@ProTip ProTip mentioned this issue Jul 1, 2018
Closed
@theblang
Copy link

theblang commented Jul 9, 2018

@ProTip @anescobar1991 This is probably due to jestjs/jest#5163 right?

@anescobar1991
Copy link
Member

@theblang yes you are right. I believe #89 is a fix

@anescobar1991
Copy link
Member

Closed by #95

@snyk-bot snyk-bot mentioned this issue May 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance serialization speed to save 3s on diff writing.
3 participants
@ProTip @theblang @anescobar1991