From 1312ac5d22ff0cf8e43ce31a661832594ea39631 Mon Sep 17 00:00:00 2001 From: Tristan F <26509014+LeoDog896@users.noreply.github.com> Date: Fri, 29 Sep 2023 22:26:04 -0400 Subject: [PATCH 1/5] ci: windows & mac --- .github/workflows/tests.yml | 3 ++- __tests__/index.spec.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index bf1d1d0..d272e8b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -7,10 +7,11 @@ on: jobs: tests: - runs-on: ubuntu-latest strategy: matrix: node: [ '14.x', '16.x', '18.x' ] + os: [ ubuntu-latest, windows-latest, macos-latest ] + runs-on: ${{ matrix.os }} name: Node ${{ matrix.node }} steps: - uses: actions/checkout@v2 diff --git a/__tests__/index.spec.js b/__tests__/index.spec.js index d12c38d..16b7cef 100644 --- a/__tests__/index.spec.js +++ b/__tests__/index.spec.js @@ -448,7 +448,7 @@ describe('toMatchImageSnapshot', () => { failureThresholdType: 'pixel', receivedImageBuffer: undefined, snapshotIdentifier: 'test-spec-js-test-1-1-snap', - snapshotsDir: 'path/to/__image_snapshots__', + snapshotsDir: process.platform === 'win32' ? 'path\\to\\__image_snapshots__' : 'path/to/__image_snapshots__', storeReceivedOnFailure: false, updatePassedSnapshot: false, updateSnapshot: false, From 3f08a23845e8374162df9a2f839dcbe23ca60e2c Mon Sep 17 00:00:00 2001 From: Tristan F <26509014+LeoDog896@users.noreply.github.com> Date: Fri, 29 Sep 2023 22:37:21 -0400 Subject: [PATCH 2/5] chore: bump to actions/checkout@v4 --- .github/workflows/health-check.yml | 2 +- .github/workflows/release.yml | 2 +- .github/workflows/tests.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/health-check.yml b/.github/workflows/health-check.yml index 4c69355..5357022 100644 --- a/.github/workflows/health-check.yml +++ b/.github/workflows/health-check.yml @@ -13,7 +13,7 @@ jobs: node: [ '14.x', '16.x', '18.x' ] name: Node ${{ matrix.node }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - run: | git remote set-branches --add origin main git fetch diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 742a877..bc242a8 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -17,7 +17,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: persist-credentials: false - name: Setup Node.js diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index d272e8b..ac3008e 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -14,7 +14,7 @@ jobs: runs-on: ${{ matrix.os }} name: Node ${{ matrix.node }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - run: | git remote set-branches --add origin main git fetch From b5a188bcd1a39cfdd1e00d6412dbe2c06019405c Mon Sep 17 00:00:00 2001 From: Tristan F <26509014+LeoDog896@users.noreply.github.com> Date: Fri, 29 Sep 2023 22:46:38 -0400 Subject: [PATCH 3/5] ci: run os on health check --- .github/workflows/health-check.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/health-check.yml b/.github/workflows/health-check.yml index 5357022..5b8ea71 100644 --- a/.github/workflows/health-check.yml +++ b/.github/workflows/health-check.yml @@ -7,10 +7,11 @@ on: jobs: tests: - runs-on: ubuntu-latest strategy: matrix: node: [ '14.x', '16.x', '18.x' ] + os: [ ubuntu-latest, windows-latest, macos-latest ] + runs-on: ${{ matrix.os }} name: Node ${{ matrix.node }} steps: - uses: actions/checkout@v4 From b0e48572c0570267c964c995258c66cb3e7c9292 Mon Sep 17 00:00:00 2001 From: Tristan F Date: Tue, 3 Oct 2023 18:58:15 -0400 Subject: [PATCH 4/5] ci: mention what OS Co-authored-by: Jonny Adshead --- .github/workflows/health-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/health-check.yml b/.github/workflows/health-check.yml index 5b8ea71..ce9c074 100644 --- a/.github/workflows/health-check.yml +++ b/.github/workflows/health-check.yml @@ -12,7 +12,7 @@ jobs: node: [ '14.x', '16.x', '18.x' ] os: [ ubuntu-latest, windows-latest, macos-latest ] runs-on: ${{ matrix.os }} - name: Node ${{ matrix.node }} + name: Node ${{ matrix.node }} - ${{ matrix.os }} steps: - uses: actions/checkout@v4 - run: | From 1f0e147ff612e811ee3ba6c3460c53148226242a Mon Sep 17 00:00:00 2001 From: Tristan F Date: Tue, 3 Oct 2023 18:58:25 -0400 Subject: [PATCH 5/5] ci: mention os x2 Co-authored-by: Jonny Adshead --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index ac3008e..63e3818 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -12,7 +12,7 @@ jobs: node: [ '14.x', '16.x', '18.x' ] os: [ ubuntu-latest, windows-latest, macos-latest ] runs-on: ${{ matrix.os }} - name: Node ${{ matrix.node }} + name: Node ${{ matrix.node }} - ${{ matrix.os }} steps: - uses: actions/checkout@v4 - run: |