From 6142118bee7aba1b59e3371e0e0173526f1eab3a Mon Sep 17 00:00:00 2001
From: Giuliano Kranevitter <giuliano.kranevitter1@aexp.com>
Date: Mon, 22 Apr 2024 16:31:20 -0400
Subject: [PATCH] chore: bumped to node 20.12.2

---
 .../workflows/on-pr-and-trunk_one-app-unit-and-lint-tests.yml | 2 +-
 .nvmrc                                                        | 2 +-
 Dockerfile                                                    | 4 ++--
 package-lock.json                                             | 2 +-
 package.json                                                  | 2 +-
 prod-sample/api/Dockerfile                                    | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/on-pr-and-trunk_one-app-unit-and-lint-tests.yml b/.github/workflows/on-pr-and-trunk_one-app-unit-and-lint-tests.yml
index d98ca31ba..093d44527 100644
--- a/.github/workflows/on-pr-and-trunk_one-app-unit-and-lint-tests.yml
+++ b/.github/workflows/on-pr-and-trunk_one-app-unit-and-lint-tests.yml
@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18.x, 20.8.1]
+        node-version: [18.x, 20.12.2]
     steps:
       - name: Checkout
         uses: actions/checkout@v4
diff --git a/.nvmrc b/.nvmrc
index 6569dfa4f..87834047a 100644
--- a/.nvmrc
+++ b/.nvmrc
@@ -1 +1 @@
-20.8.1
+20.12.2
diff --git a/Dockerfile b/Dockerfile
index 7d65342eb..230193a34 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -3,7 +3,7 @@ ARG VERSION=lts
 # which includes build utils preinstalled (e.g. gcc, make, etc).
 # This will result in faster and reliable One App docker image
 # builds as we do not have to run apk installs for alpine.
-FROM node:$VERSION-alpine as builder
+FROM node:$VERSION-alpine3.18 as builder
 WORKDIR /opt/build
 RUN npm install -g npm@9.9.3 --registry=https://registry.npmjs.org
 COPY --chown=node:node ./ /opt/build
@@ -30,7 +30,7 @@ RUN NODE_ENV=production npm run build && \
     mv /opt/build/.build-meta.json /opt/one-app/production
 
 # https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#handling-kernel-signals
-FROM node:$VERSION-alpine as node-tini
+FROM node:$VERSION-alpine3.18 as node-tini
 RUN apk add --no-cache tini
 ENTRYPOINT ["/sbin/tini", "--"]
 
diff --git a/package-lock.json b/package-lock.json
index af95470a9..e888d544f 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -133,7 +133,7 @@
         "webdriverio": "^7.36.0"
       },
       "engines": {
-        "node": ">=18 <=20.8.1",
+        "node": ">=18 <=20.12.2",
         "npm": ">=9"
       }
     },
diff --git a/package.json b/package.json
index 23d9507ba..31520adf1 100644
--- a/package.json
+++ b/package.json
@@ -4,7 +4,7 @@
   "description": "One Amex SPA technology stack.",
   "main": "index.js",
   "engines": {
-    "node": ">=18 <=20.8.1",
+    "node": ">=18 <=20.12.2",
     "npm": ">=9"
   },
   "scripts": {
diff --git a/prod-sample/api/Dockerfile b/prod-sample/api/Dockerfile
index 8f0e50a78..0f86f6211 100644
--- a/prod-sample/api/Dockerfile
+++ b/prod-sample/api/Dockerfile
@@ -1,6 +1,6 @@
 ARG VERSION=lts
 
-FROM node:$VERSION-alpine as builder
+FROM node:$VERSION-alpine3.18 as builder
 MAINTAINER One App Team
 
 WORKDIR /