feat(fetch): switch to cross-fetch instead of isomorphic-fetch

[JAdshead]

Description

Switching to cross-fetch instead of isomorphic-fetch as the later has not been maintained for 5 years.

Motivation and Context

isomorphic-fetch as the later has not been maintained for 5 years and provides outdated versions of both node-fetch and WHATWG fetch

How Has This Been Tested?

Unit and integration tests.

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation (adding or updating documentation)

Checklist:

• My change requires a change to the documentation and I have updated the documentation accordingly.
• These changes should be applied to a maintenance branch.
• This change requires cross browser checks.
• Performance tests should be ran against the server prior to merging.
• This change impacts caching for client browsers.
• This change impacts HTTP headers.
• This change adds additional environment variable requirements for One App users.
• I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Provides a fetch that is closer to the spec.

[oneamexbot]

📊 Bundle Size Report

file name	size on disk	gzip
app.js	112.6KB	31.4KB
runtime.js	15KB	5.3KB
vendors.js	128.1KB	37.9KB
app~vendors.js	405.9KB	106KB
legacy/app.js	119.4KB	33KB
legacy/runtime.js	15KB	5.3KB
legacy/vendors.js	163.2KB	44.9KB
legacy/app~vendors.js	412KB	107.6KB

Generated by 🚫 dangerJS against 668ac96

[infoxicator]

@JAdshead Integration tests pass so looks like everything is working same as with isomorphic-fetch 😁, if I want to run some manual tests, is this the only dep I need? "@americanexpress/one-app-bundler": "^6.4.0",

[JAdshead]

@JAdshead Integration tests pass so looks like everything is working same as with isomorphic-fetch 😁, if I want to run some manual tests, is this the only dep I need? "@americanexpress/one-app-bundler": "^6.4.0",

I think you just need to be running this branch of the app. modules should not know about which fetch client is provided as its polyfilled

[infoxicator]

package-lock.json conflict needs fixing 👍

[mtomcal]

This looks good and given how many Integration tests where we use fetch this gives me confidence this is a non breaking swapout.