Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(circuit): disable circuit breaker in development #307

Merged
merged 12 commits into from
Sep 30, 2020

Conversation

nellyk
Copy link
Contributor

@nellyk nellyk commented Sep 17, 2020

Description

Disabling the circuit breaker in development environment

Motivation and Context

Currently during local development the circuit breaker opens up and causes a lot of log generation. This is usually useful but for the development environment it doesn't provide for a seamless experience when creating experiences

How Has This Been Tested?

Unit tests have been added

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

NA

@nellyk nellyk requested review from a team as code owners September 17, 2020 13:02
@github-actions github-actions bot added the fix label Sep 17, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 276.2KB 82.4KB
runtime.js 15KB 5.4KB
vendors.js 117.4KB 36.4KB
app~vendors.js 425.2KB 111KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 291.4KB 85.6KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 172.9KB 47.1KB
legacy/app~vendors.js 439.9KB 114.1KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against 3935f6a

JAdshead
JAdshead previously approved these changes Sep 17, 2020
@nellyk
Copy link
Contributor Author

nellyk commented Sep 18, 2020

autocannon tests

Before this changes

Screenshot 2020-09-18 at 14 15 06

With this changes
Screenshot 2020-09-18 at 14 11 13

mtomcal
mtomcal previously approved these changes Sep 22, 2020
@JAdshead JAdshead self-requested a review September 22, 2020 18:41
Co-authored-by: Jonny Adshead <JAdshead@users.noreply.github.com>
infoxicator
infoxicator previously approved these changes Sep 29, 2020
JamesSingleton
JamesSingleton previously approved these changes Sep 29, 2020
JAdshead
JAdshead previously approved these changes Sep 29, 2020
@nellyk nellyk changed the base branch from master to main September 29, 2020 18:14
@nellyk nellyk dismissed stale reviews from JAdshead, JamesSingleton, infoxicator, and 10xLaCroixDrinker September 29, 2020 18:14

The base branch was changed.

@nellyk nellyk merged commit 1d87967 into main Sep 30, 2020
@nellyk nellyk deleted the fix/circuit-breaker-disable-dev branch September 30, 2020 12:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants