Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(metrics): track intl cache size #406

Merged
merged 6 commits into from
Jan 13, 2021
Merged

Conversation

JAdshead
Copy link
Contributor

Description

Track intl cache size

Motivation and Context

This will allow us to track the changes in lang pack caching overtime

How Has This Been Tested?

locally using the prod-sample and unit tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JAdshead JAdshead requested review from a team as code owners January 12, 2021 18:25
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2021

Warnings
⚠️

Changes were made to package-lock.json, but not to package.json - Are you reverting package-lock to the npm v5 format?

📊 Bundle Size Report

file name size on disk gzip
app.js 276KB 81.5KB
runtime.js 15.6KB 5.5KB
vendors.js 124.8KB 38.3KB
app~vendors.js 429.9KB 112.4KB
service-worker-client.js 17.1KB 5.3KB
legacy/app.js 296.4KB 86KB
legacy/runtime.js 15.6KB 5.5KB
legacy/vendors.js 183.1KB 49.5KB
legacy/app~vendors.js 453.5KB 118.3KB
legacy/service-worker-client.js 17.6KB 5.5KB

Generated by 🚫 dangerJS against 9a73c16

@infoxicator
Copy link
Contributor

@JAdshead I think you mentioned before but can you write here how is the size collected overtime and the workaround so we don't have to use the module map poll

Co-authored-by: Ruben Casas <ruben@infoxication.net>

collectDefaultMetrics();
metricsRegister.registerCollector(cacheSizeCollector);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@infoxicator the register ensures that the cacheSizeCollector is called in the same manor default metrics are collected

@JAdshead JAdshead merged commit de65e10 into main Jan 13, 2021
@JAdshead JAdshead deleted the feat/track-intl-server-cache branch January 13, 2021 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants