This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAdshead
suggested changes
Jan 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good idea and might be worth including on our other packages if everyone agrees.
JAdshead
suggested changes
Jan 6, 2020
Should we just add |
I think i would prefer it staying with danger as we are validating whether the package-lock submitted via the pr is valid. It would be still be captured. |
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
Francois-Esquire
force-pushed
the
feature/lockfile-validation
branch
from
January 13, 2020 19:15
bf52a41
to
07e2fd2
Compare
@nellyk @anescobar1991 updated to use command-line tool per team discussion. |
10xLaCroixDrinker
suggested changes
Jan 13, 2020
anescobar1991
approved these changes
Jan 14, 2020
nellyk
approved these changes
Jan 14, 2020
mtomcal
approved these changes
Jan 14, 2020
10xLaCroixDrinker
approved these changes
Jan 14, 2020
JAdshead
approved these changes
Jan 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extendsdanger.js
to validate lock files, hosts and protocol of package resolutions are checked.Adding
lockfile-lint
to run ontest:lint
script.