Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows support? #40

Closed
fmal opened this issue Nov 2, 2016 · 7 comments
Closed

windows support? #40

fmal opened this issue Nov 2, 2016 · 7 comments
Labels

Comments

@fmal
Copy link

fmal commented Nov 2, 2016

I'm using latest version of the plugin with up-to-date Atom, linter-eslint and linter. My machine is running Windows 8.1 64-bit. When i trigger eslint from cli errors show up correctly, however i'm not able to see them in Atom ui. Errors from the plugin are somehow swallowed, while all the other rules validate just fine. Has anyone managed to get Atom linting working on windows?

@amilajack
Copy link
Owner

Last time I checked on windows, it did work. I'll test this out over the weekend.

@amilajack amilajack added the bug label Nov 2, 2016
@ryancole
Copy link

I was coming here to open an issue regarding this, as well. I recall this used to work at some point in the past but no longer seems to work. When I run eslint via CLI, I see the flow errors from this plugin. When I open a file via Atom, I don't see any of the errors from this plugin, but I will see other eslint errors.

Here is my eslint config ...

{
  "parser": "babel-eslint",
  "parserOptions": {
    "sourceType": "module",
    "ecmaVersion": 6,
    "ecmaFeatures": {
      "jsx": true,
      "impliedStrict": true,
      "experimentalObjectRestSpread": true
    }
  },
  "env": {
    "es6": true,
    "jest": true,
    "node": true,
    "browser": true
  },
  "plugins": [
    "react",
    "flowtype-errors"
  ],
  "extends": [
    "eslint:recommended",
    "plugin:react/recommended"
  ],
  "rules": {
    "quotes": ["error", "double"],
    "no-console": "off",
    "flowtype-errors/show-errors": 2
  }
}

I'm also on Windows, using latest version of Atom and this plugin.

@amilajack
Copy link
Owner

amilajack commented Jan 27, 2017

Are you on a 32bit or 64bit machine?

@ryancole
Copy link

ryancole commented Jan 27, 2017

@amilajack Windows 10 64-bit. Although, it looks like Atom runs as 32-bit, based on the version string, which is 1.13.1 ia32. That probably doesn't affect flow bin, though.

@amilajack
Copy link
Owner

Flow isnt supported on 32 bit machines. See #46. I'll try to check this out over the weekend

@ryancole
Copy link

Just to be clear, this plugin does work via eslint CLI. I see the errors when I run eslint CLI. So, the plugin is working there. I just don't appear to be seeing the errors in Atom, for some reason.

@amilajack
Copy link
Owner

amilajack commented Jan 30, 2017

I just confirmed that this plugin does not work on the 32 bit atom (because flow isnt supported on 32bit environments). You can download the the 64bit version of atom from the downloads section of the latest release

screen shot 2017-01-29 at 9 24 43 pm

I confirmed that this works on the 64 bit version of atom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants