Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Which style of docstrings to use? #20

Closed
sbellem opened this issue Aug 17, 2017 · 2 comments
Closed

[docs] Which style of docstrings to use? #20

sbellem opened this issue Aug 17, 2017 · 2 comments
Labels

Comments

@sbellem
Copy link
Contributor

sbellem commented Aug 17, 2017

I would like to help in with the documentation of the code, and noticed different styles being used.

In some places it's the normal standard docstrings, as in:

def binaryagreement(sid, ...):
    '''Binary consensus ...

    :param sid: session identifier
    '''

while in other places it seems to be the NumPy style such as in:

def reliablebroadcast(sid, pid, ...):
    """Reliable broadcast

    Args
    ----
    pid : 0 <= pid < N

    """

More generally, as far as I know there are three possible approaches:

The google and numpy styles are available via the sphinx.ext.napoleon module.

Assuming that help is welcomed, then if a style is chosen I could help with setting up the documentation boilerplate, etc such that some documentation could be hosted on readthedocs for instance, or wherever you wish.

@amiller
Copy link
Owner

amiller commented Aug 22, 2017

Help is most definitely welcomed, thank you being here and what you've done so far!
Let's do standard docstrings as I don't have either "domain-specific" or "legacy" reasons to use something different.

@amiller
Copy link
Owner

amiller commented Aug 22, 2017

I'm optimistically assuming you'll agree with this, and closing it as "decision made." Feel free to reopen if we need to consider anything else before choosing to adopt it. Maybe a separate issue will be needed to ensure existing documentation if useful is converted over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants