Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: remove redundant clang-tidy arguments to avoid possible bugs #272

Closed
FeignClaims opened this issue Aug 13, 2024 · 1 comment

Comments

@FeignClaims
Copy link
Contributor

FeignClaims commented Aug 13, 2024

According to the cmake implementation code, especially this comment, clang-tidy can normally accept all compiler command line arguments after --, so there's redundant work in StaticAnalyzers.cmake.

This, however, might require a difficult review of the code.

Upvote & Fund

@aminya is using Polar.sh so you can upvote and help fund this issue. The funding is received once the issue is completed & confirmed by you.

Thank you in advance for helping prioritize & fund our backlog!


Fund with Polar
@aminya
Copy link
Owner

aminya commented Sep 11, 2024

I don't think we can fix it in project_options.

I opened an issue upstream:
https://gitlab.kitware.com/cmake/cmake/-/issues/26283

I tried passing this, but it didn't help

  CLANG_TIDY_EXTRA_ARGUMENTS
  "-extra-arg=-Wno-unknown-warning-option;-extra-arg=-Wno-error=unused-command-line-argument;-extra-arg=-Wno-unused-command-line-argument;-extra-arg=-Qunused-arguments"

Closing in favour of the upstream issue.

@aminya aminya closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants