Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add support for notify_days_after #4

Open
amitchone opened this issue Oct 23, 2023 · 0 comments
Open

Re-add support for notify_days_after #4

amitchone opened this issue Oct 23, 2023 · 0 comments
Assignees
@amitchone
Labels
enhancement New feature or request

Comments

@amitchone
Copy link
Owner

This feature was removed when correcting the year rollover bug that caused birthdays in the next calendar year not to be calculated.

notify_days_after was an option to allow birthdays to be displays after the date for a configurable number of days - one use case for this could be after returning from a vacation to find that you have potentially missed a birthday.

Should be easy enough to implement, but some logic will be required to ensure that notify_days_after does not overlap with notify_days_before.
@amitchone amitchone self-assigned this Oct 23, 2023
@amitchone amitchone added the enhancement New feature or request label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amitchone amitchone

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amitchone