Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening url with special characters doesn't work correctly on wsl #73

Closed
SolomonRosemite opened this issue Aug 16, 2023 · 4 comments · Fixed by #74
Closed

Opening url with special characters doesn't work correctly on wsl #73

SolomonRosemite opened this issue Aug 16, 2023 · 4 comments · Fixed by #74

Comments

@SolomonRosemite
Copy link

SolomonRosemite commented Aug 16, 2023

When opening a browser with the following url https://accounts.spotify.com/authorize?response_type=code&redirect_uri=http%3A%2F%2Flocalhost%3A8080%2Fcallback&client_id=x&state=y&scope=user-read-recently-played the browser opens successfully but instead of landing on the expected url, the browser lands here https://accounts.spotify.com/authorize?response_type=code.
Cutting off everything after the "&" character.

When trying to reproduce this using the command from here:

try_browser!(options, "cmd.exe", "/c", "start", url)

I get the same result and the following output:

C:\Users\solomon>start https://accounts.spotify.com/authorize?response_type=code&redirect_uri=http%3A%2F%2Flocalhost%3A8080%2Fcallback&client_id=x&state=y&scope=user-read-recently-played
'redirect_uri' is not recognized as an internal or external command,
operable program or batch file.
'client_id' is not recognized as an internal or external command,
operable program or batch file.
'state' is not recognized as an internal or external command,
operable program or batch file.
'scope' is not recognized as an internal or external command,
operable program or batch file.

However, with the help of this, changing the command to the following seemed to work for me:

C:\Users\solomon>start "" "https://accounts.spotify.com/authorize?response_type=code&redirect_uri=http%3A%2F%2Flocalhost%3A8080%2Fcallback&client_id=x&state=y&scope=user-read-recently-played"

Let me know if any more info needed.

@amodm
Copy link
Owner

amodm commented Aug 16, 2023

Can you try once with the code in the fix/issue-73 branch? 3da3e74

It seems to work in my WSL sandbox, but would prefer your verification before merging this to main.

@amodm
Copy link
Owner

amodm commented Aug 17, 2023

@SolomonRosemite I'll wait a couple of days to hear from you, else I'll assume this fix (and my testing) to be sufficient.

@SolomonRosemite
Copy link
Author

Seems to work perfectly. Thanks!

@amodm amodm closed this as completed in #74 Aug 17, 2023
@amodm
Copy link
Owner

amodm commented Aug 17, 2023

Awesome, thanks for the quick confirmation! This is now released as v0.8.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants