Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amplitude client using ForkJoinPool for I/O #108

Closed
kevink-sq opened this issue Aug 28, 2024 · 2 comments
Closed

Amplitude client using ForkJoinPool for I/O #108

kevink-sq opened this issue Aug 28, 2024 · 2 comments

Comments

@kevink-sq
Copy link
Contributor

Expected Behavior

sendEvents should use sendThreadPool instead of the default ForkJoinPool.

Current Behavior

sendEvents uses the default ForkJoinPool via CompletableFuture.supplyAsync(runnable) which scales with the number of cpu.

Possible Solution

See #107
@kevink-sq kevink-sq mentioned this issue Aug 28, 2024
Merged
1 task
@kevink-sq
Copy link
Contributor Author

cc: @izaaz

@izaaz
Copy link
Contributor

izaaz commented Oct 10, 2024

@kevink-sq this should be released now. Thank you for making the change in the repo and testing this out!

@izaaz izaaz closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@izaaz @kevink-sq