-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add screen name to elementInteractions properties for autocapture #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r configuration is created
…to defaultTracking
…ltTracking options
This reverts commit afad034.
…tive for autocapture
…apture options entirely.
# Conflicts: # android/src/main/java/com/amplitude/android/internal/gestures/AutocaptureGestureListener.kt # android/src/test/java/com/amplitude/android/internal/gestures/AutocaptureGestureListenerClickTest.kt
Mercy811
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pouria, LGTM.
yuhao900914
approved these changes
Aug 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
# [1.17.0](v1.16.8...v1.17.0) (2024-08-08) ### Bug Fixes * extract ComposeUtils to share with plugins ([#202](#202)) ([c239bba](c239bba)) * fix release pipeline ([#211](#211)) ([816599f](816599f)) * revert autocapture scroll and swipe ([#206](#206)) ([4b834bd](4b834bd)) ### Features * add autocapture for element clicks ([#199](#199)) ([7f0a500](7f0a500)) * add autocapture in configs ([#207](#207)) ([dcb9393](dcb9393)) * add screen name to elementInteractions properties for autocapture ([#209](#209)) ([8044122](8044122)) * add scroll and swipe autocapture ([#201](#201)) ([1a5a392](1a5a392))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds screen name to
elementInteractions
properties for autocapture.Checklist