From e1710f1d98317a1c34702db69b20f2d3cec79f49 Mon Sep 17 00:00:00 2001 From: tyiuhc <137842098+tyiuhc@users.noreply.github.com> Date: Thu, 24 Aug 2023 16:43:07 -0700 Subject: [PATCH] fix: Auto assignment tracking insert_id timestamp round to integer (#30) --- packages/node/src/assignment/assignment-service.ts | 2 +- .../node/test/local/assignment/assignment-service.test.ts | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/node/src/assignment/assignment-service.ts b/packages/node/src/assignment/assignment-service.ts index 4dba206..0794990 100644 --- a/packages/node/src/assignment/assignment-service.ts +++ b/packages/node/src/assignment/assignment-service.ts @@ -57,7 +57,7 @@ export class AmplitudeAssignmentService implements AssignmentService { event.insert_id = `${event.user_id} ${event.device_id} ${hashCode( assignment.canonicalize(), - )} ${assignment.timestamp / DAY_MILLIS}`; + )} ${Math.floor(assignment.timestamp / DAY_MILLIS)}`; return event; } } diff --git a/packages/node/test/local/assignment/assignment-service.test.ts b/packages/node/test/local/assignment/assignment-service.test.ts index 77ee526..f6b72e0 100644 --- a/packages/node/test/local/assignment/assignment-service.test.ts +++ b/packages/node/test/local/assignment/assignment-service.test.ts @@ -49,9 +49,9 @@ test('assignment to event as expected', async () => { expect(Object.keys(userProperties['$set']).length).toEqual(1); expect(Object.keys(userProperties['$unset']).length).toEqual(1); const canonicalization = 'user device flag-key-1 on flag-key-2 control '; - const expected = `user device ${hashCode(canonicalization)} ${ - assignment.timestamp / DAY_MILLIS - }`; + const expected = `user device ${hashCode(canonicalization)} ${Math.floor( + assignment.timestamp / DAY_MILLIS, + )}`; expect(event.insert_id).toEqual(expected); });