Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update AmplitudeCookies util to support new cookie format #53

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

tyiuhc
Copy link
Collaborator

@tyiuhc tyiuhc commented Sep 25, 2023

Summary

Update AmplitudeCookies util to support new cookie format

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

Copy link
Collaborator

@bgiori bgiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the old function as well, some customers may be using an old SDK and still want to parse the old cookie.

@bgiori
Copy link
Collaborator

bgiori commented Sep 25, 2023

Specifically, keep the old functions exactly as they are, and add new functions.

Copy link
Collaborator

@bgiori bgiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sorry

@tyiuhc tyiuhc merged commit 8336cf8 into main Sep 25, 2023
4 checks passed
@tyiuhc tyiuhc deleted the new-cookie-util branch September 25, 2023 17:06
github-actions bot pushed a commit that referenced this pull request Sep 25, 2023
## [1.2.3](v1.2.2...v1.2.3) (2023-09-25)

### Bug Fixes

* Update AmplitudeCookies util to support new cookie format ([#53](#53)) ([8336cf8](8336cf8))
@github-actions
Copy link

🎉 This PR is included in version 1.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants