Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InvalidOptionValue exception to throw exception for invalid option value #454

Closed
ediamin opened this issue Dec 21, 2021 · 0 comments · Fixed by #455
Closed

Add InvalidOptionValue exception to throw exception for invalid option value #454

ediamin opened this issue Dec 21, 2021 · 0 comments · Fixed by #455
Assignees
@ediamin
Milestone
0.11.0

Comments

@ediamin
Copy link
Collaborator

ediamin commented Dec 21, 2021

Classes/methods that take argument as option should be able to throw an exception when we try to set an invalid one. InvalidOptionValue will serve that purpose. For example, AmpBindAttributes filter should throw error when we try to set an invalid value for Option::AMP_BIND_SYNTAX option.
@ediamin ediamin self-assigned this Dec 21, 2021
This was referenced Dec 21, 2021
Merged
Merged
@westonruter westonruter added this to the 0.11.0 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ediamin ediamin

Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Add InvalidOptionValue exception ampproject/amp-toolbox-php
2 participants
@westonruter @ediamin