-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update validator spec for <amp-story-audio-sticker>
#542
Comments
The spec in amp-toolbox-php isn't actually used by Web Stories, is it? Isn't it the spec that is consumed by the AMP plugin for the Note that |
Ah right. Okay, so in that case the AMP plugin needs to be updated as well. |
Note: While ampproject/amp-wp#7597 updated the spec in the plugin, the latest AMP release doesn't yet include |
https://cdn.ampproject.org/v0/validator.json hs now been updated to include this. Please correct me if I'm wrong, but I think some update in this repo is still required because of the optimizer, which relies on the spec. And the Web Stories plugin uses the optimizer. |
The AMP plugin actually doesn't use the Optimizer for sanitization or validation (which would depend on #195). It's all still handled internally in the plugin. Unless the Optimizer needs to be updated with special handling to SSR the |
This new
amp-story-audio-sticker
extension has been added recently, see ampproject/amphtml#39184It doesn't show up on https://cdn.ampproject.org/v0/validator.json yet, but once it does it would be nice to update the spec in this repo so that we could use this new element in the Web Stories for WordPress project.
The text was updated successfully, but these errors were encountered: