Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist shortcode support #1279

Closed
philipjohn opened this issue Jul 24, 2018 · 1 comment
Closed

Playlist shortcode support #1279

philipjohn opened this issue Jul 24, 2018 · 1 comment

Comments

@philipjohn
Copy link
Contributor

Although support for the core playlist shortcode was added in #954 I'm seeing a fairly unattractive implementation that doesn't match with what I see in that PR.

On a vanilla WP install I have a post with the following content:

[playlist ids="1709,1708,821"]

Which is rendered like so in twentyseventeen:

rendered-playlist

The AMP (paired) playlist is rendered like so:

amp-rendered-playlist

It looks like maybe the styles are missing - snipped out by the transformer maybe?

@westonruter
Copy link
Member

@philipjohn It looks like in this case the legacy templates are being used? I believe the support depends on AMP theme support because the MediaElement CSS needs to be enqueued. If you enable AMP theme support does it tender better? To add support for the legacy templates then the CSS from the external stylesheet would need to get fetched and output.

@kienstra kienstra closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants