Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert block validation script to a module, and bundle it with block toggle module #1298

Closed
kienstra opened this issue Jul 31, 2018 · 5 comments

Comments

@kienstra
Copy link
Contributor

kienstra commented Jul 31, 2018

AC1. Convert amp-block-validation.js to an ES6 module
AC2. Create a new file that will import both this module and amp-block-editor-toggle.js (though that might have since been renamed). This can be similar to blocks/index.js.
AC3. Add that new file with the import statements to webpack.config.js, so it will be compiled with npm run dev
AC4. Ensure that the compiled files have sourcemaps.

This should probably wait for the work on amp-block-validation.js in #1293

@kienstra
Copy link
Contributor Author

Hi @postphotos,
If it's alright, I opened this issue with basic ACs. Feel free to edit this if you'd like.

This arose from the work on #1275 (comment).

@westonruter westonruter added this to the v1.0 milestone Jul 31, 2018
@hellofromtonya
Copy link
Contributor

@kienstra PR #1293 is now merged. You have a green light to convert the amp-block-validation.js script into an E6 module.

@kienstra
Copy link
Contributor Author

kienstra commented Aug 1, 2018

Thanks, @hellofromtonya! I'm not sure if I'll work on this issue soon, though. In the meantime, this is free for anyone to pick up.

@kienstra
Copy link
Contributor Author

Adding Another Script To The Requirements

Per this conversation, please also convert amp-invalid-url-post-edit-screen.js to an ES6 module.

@westonruter westonruter removed this from the v1.0 milestone Sep 21, 2018
@westonruter
Copy link
Member

I'm going to close this because this will come automatically once we refactor the admin screens to use JS-driven interfaces as opposed to the PHP-driven ones we've largely tried to re-use from what WordPress provides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants