Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the border in the AMP Story interface to be more apparent for pages #1522

Closed
1 task
alcurrie opened this issue Oct 23, 2018 · 6 comments
Closed
1 task
Labels
Enhancement New feature or improvement of an existing one
Milestone

Comments

@alcurrie
Copy link

alcurrie commented Oct 23, 2018

As an editor creating an AMP story, I'd like there to be a more apparent border for pages in the AMP Stories editor

@alcurrie
Copy link
Author

alcurrie commented Nov 1, 2018

@jwold though this task design change, this doesn't seem like this needs design UX feedback as the screenshot in the AC is fairly straightforward, though it may make sense to include it in the overall look at design/UX changes needed.

@alcurrie alcurrie added the UX label Nov 1, 2018
@jwold
Copy link
Collaborator

jwold commented Nov 1, 2018

For this issue Mike will take a stab at what it looks like and then submit it for UX feedback.

@jwold jwold removed the UX label Nov 1, 2018
@miina miina added UX FE and removed UX labels Nov 1, 2018
@jwold
Copy link
Collaborator

jwold commented Nov 14, 2018

This has been discussed in #1564, proposing what the border should look like. Feeling pretty good with where we've landed.

@mehigh mehigh self-assigned this Nov 15, 2018
@alcurrie
Copy link
Author

@mehigh - for additional clarification I've updated the AC to show the reference to border, but as @jwold notes this is also shown in the latest designs discussed/posted in #1564

@mehigh
Copy link
Contributor

mehigh commented Nov 22, 2018

The colors have been updated and now the page looks like this: http://cloud.urldocs.com/26f832e554cd
Closing as it was merged this along the fixes for 1524
Moving it on to QA.

@mehigh mehigh closed this as completed Nov 22, 2018
@mehigh mehigh assigned alcurrie and unassigned mehigh Nov 22, 2018
@alcurrie
Copy link
Author

alcurrie commented Dec 3, 2018

Confirmed: https://cl.ly/8da2559e0382

@alcurrie alcurrie removed their assignment Dec 3, 2018
@westonruter westonruter added this to the v1.2 milestone May 21, 2019
@swissspidy swissspidy added Enhancement New feature or improvement of an existing one and removed AMP-Stories-Extension labels Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one
Projects
None yet
Development

No branches or pull requests

6 participants