-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discovery - define which page elements should be zoomed, and which should not #2791
Comments
So there is this interesting WIP pull request on the Gutenberg repository which also introduces that notion of zooming. |
Looks like the WIP PR got closed, also, it looks like it's purpose was more similar to the Instagram-like focus than actual Zooming -- it seemed to separate the block for editing without distractions. To clarify:
Did you understand something like this or something different over the call today? Would appreciate your thoughts. cc @kienstra @swissspidy |
Hi @miina, a) Yes, I think it was mentioned that the elements that appear on the front-end should be able to zoom, like the Page. While any editor-specific elements, like the toolbar, shouldn't be able to. b) I'm not sure if there was discussion about 'programmatically zooming' in the call, though that's not to say it doesn't apply. I'm not sure about the specifics about how it would happen. |
If with "default zoom" you mean zooming in the browser using Ctrl++ / Ctrl+-, then I don't think it's technically possible to restrict this to a certain area. Nor would that be advisable to implement.
Yes, that was my understanding. Click on zoom button -> page is displayed bigger, which makes it easier to edit -> block toolbar etc. stay small. |
Yep, 100% agreed with that.
Looks like one option for doing that could be using scaling via Found an example (see under "Zooming inside a container") searching which uses |
Is the main goal of this feature to be able to have better editing experience by zooming into the currently active page? Or was there any other goal behind it? One option could be adding just one zooming point, e.g. zoom in for scaling X% and zoom back out. Another thing to consider is that if we're zooming just the one active page then this means that the room that we have for this page would need to stay the same (since everything else around it is staying the same), so we should handle the zoom within a container. An alternative could be having a "zoom mode" (a bit more similar idea to the upstream PR that got closed) which would:
Not sure. Thoughts? |
My understanding was that this would allow for a better editing experience because zooming in on the current page would hide the other elements like the menus, etc. (since you want to focus on editing that page). So more like the second version you describe. |
Checking my understanding: So this is similar editing a post using elements of classic editor in "Distraction Free Mode" without removing the document and block editor and tools. |
Correct, and with displaying the Page larger as normal as well ("zoomed"). We'll discuss/confirm this in a few hours today. |
As a user I want to be able to zoom out/in elements on the editor page. Not all elements should be capable of zoom in/out.
AC1: Discovery - define which page elements should be zoomed, and which should not (e.g. Navigation, block borders)
The text was updated successfully, but these errors were encountered: