-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with Invalid attribute: label #4531
Comments
Could you please navigate to review the issues on the Validated URL screen? Specifically expand the full details down the issue with the |
Actually, I can see the issue is with this heading block: <!-- wp:heading {"align":"center","level":4} -->
<h4 class="has-text-align-center"><a href="https://www.asheventsllc.com/" target="_blank" rel="noreferrer noopener" label="Ash Events (opens in a new tab)">Ash Events</a></h4>
<!-- /wp:heading --></div> Somehow the |
The AMP validation error you see (in the Chrome AMP validator extension?) is most likely because of the presence of the |
In other words, the AMP validator won't find AMP validation errors when it checks the site because the admin bar won't be present: https://validator.amp.dev/#url=https%3A%2F%2Fwww.ryansmithphotography.com%2Frecommended-wedding-vendors%2F |
Thanks for the help, that cleared up the error! Sorry if I was confusing I understand about the ampdevmode. I didn't mean the page wouldn't validate as amp just that the wordpress toolbar reported the validation error and the block editor, I wasn't really clear about what I meant. Thanks for the help I should have seen that issue myself. By the way, have you tested the latest 8.4.1 version of Jetpack with amp? I've lost my admin bar on pages, it's almost like how it used to be with overbudget css before you implemented the ampdevmode. I've tested removing jetpack fixes the issue. I didn't want to make another bug report if it's just something I'm doing wrong. Thanks! |
Oh yes, I'm seeing this now too. Someone else also reported this issue to me but I wasn't able to reproduce it before. But now I can for some reason. It was working in Jetpack 8.3 but now in 8.4.1 it is missing. I'll reach out to Automattic to see if anyone knows what's going on. Otherwise, I'll open an issue to investigate. |
@rsmith4321 Here's the cause: Automattic/jetpack#14840 (review) Quick fix you can put in a plugin or your custom theme's add_filter( 'show_admin_bar', 'is_user_logged_in', 11 ); As a standalone plugin: https://gist.github.com/westonruter/d168c290d6c01c107da960d48fa3dad3 |
Thanks, yes that seemed to fix the issue! |
Bug Description
I just started having an issue where it will report a block has Invalid attribute: label. Clicking remove block does nothing. Also I've examined the code view carefully and the block has no tags of any kind. I just can't figure out what is causing the error. When I view the live page outside the editor it also report the amp violation although it removes it.
Expected Behaviour
The block does not have any invalid attributes so none should be reported.
Steps to reproduce
You can view the page here although you probably can't see any issues without logging in. If you would like a login let me know. https://www.ryansmithphotography.com/recommended-wedding-vendors/
Screenshots
https://1drv.ms/u/s!AoMMKB1n71rAmY9qSLGXPSwtPvLG9A?e=ZOAfDY
Additional context
Here is the code editor code from the page:
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: