Version 0.6 get_support_errors() filter?

[ktmn]

I have previously provided support in a theme for having a chosen page as AMP front page by manually changing the global WP_Query, setting proper template and calling amp_prepare_render() when applicable.

0.6 introduced a problem when trying to render an AMP front page that is also the main front page due to this code here:

// Homepage and page for posts are not supported yet.
if ( 'page' === get_post_type( $post ) && 'page' === get_option( 'show_on_front' ) ) {
	if ( (int) get_option( 'page_for_posts' ) === (int) $post->ID ) {
		$errors[] = 'page-for-posts';
	} elseif ( (int) get_option( 'page_on_front' ) === (int) $post->ID ) {
		$errors[] = 'page-on-front';
	}
}

It forces the AMP to be disabled in the metabox and redirects to canonical when visiting it.

I think if the AMP_Post_Type_Support::get_support_errors() return array had a filter I could just unset the 'page-for-posts' and 'page-on-front' error values and would be able to keep the support for front pages.

[westonruter]

@ktmn I have written up a proposal for what I think would be a better solution than adding a new filter: #837 (comment)

Please review.

[ktmn]

Looks good

[westonruter]

@ktmn would you test #872?

[ktmn]

Works well, thank you

[westonruter]

@ktmn can you share your code that mutates WP_Query? That code would seem to be needed by the plugin in order for the front page to render as AMP when the query var is present.

[westonruter]

@ktmn actually, take a look at c9acad7

[ktmn]

Yeah that works, replaces my custom implementation.