From c8ad3d1f763a28a9805e7828c90e23c42e15be68 Mon Sep 17 00:00:00 2001 From: "robin.van-opstal@jvm.de" Date: Mon, 8 Apr 2019 12:11:27 +0200 Subject: [PATCH 1/2] fix get involved banner color --- frontend/scss/components/organisms/banner.scss | 10 +++++----- .../documentation/guides-and-tutorials/index.ads.html | 2 +- .../guides-and-tutorials/index.email.html | 2 +- .../documentation/guides-and-tutorials/index.html | 2 +- .../guides-and-tutorials/index.stories.html | 2 +- .../guides-and-tutorials/index.websites.html | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/frontend/scss/components/organisms/banner.scss b/frontend/scss/components/organisms/banner.scss index aa2e4b4060e..5b6fcdf5ddd 100644 --- a/frontend/scss/components/organisms/banner.scss +++ b/frontend/scss/components/organisms/banner.scss @@ -16,18 +16,18 @@ .#{utility('banner')} { margin: 0 -30px; - padding: 30px 30px; + padding: 60px 30px; background-color: color('blue-ribbon'); @media (min-width: 930px) { - padding: 70px 90px 70px 90px; + padding: 90px; } } .#{organism('banner')} { - - &-headline, &-copy { - color: color('white') !important; + &-headline, &-copy { + display: block; max-width: 720px; + color: color('white'); } } diff --git a/pages/content/amp-dev/documentation/guides-and-tutorials/index.ads.html b/pages/content/amp-dev/documentation/guides-and-tutorials/index.ads.html index d8a2fa7f447..4df5788cc59 100644 --- a/pages/content/amp-dev/documentation/guides-and-tutorials/index.ads.html +++ b/pages/content/amp-dev/documentation/guides-and-tutorials/index.ads.html @@ -155,5 +155,5 @@

Featured Videos

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}

Get Involved

-

AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.

+ AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.
diff --git a/pages/content/amp-dev/documentation/guides-and-tutorials/index.email.html b/pages/content/amp-dev/documentation/guides-and-tutorials/index.email.html index 3fc4d91e0c4..6f21487f4d9 100644 --- a/pages/content/amp-dev/documentation/guides-and-tutorials/index.email.html +++ b/pages/content/amp-dev/documentation/guides-and-tutorials/index.email.html @@ -155,5 +155,5 @@

Featured Videos

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}

Get Involved

-

AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.

+ AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.
diff --git a/pages/content/amp-dev/documentation/guides-and-tutorials/index.html b/pages/content/amp-dev/documentation/guides-and-tutorials/index.html index bc29a6dea48..c2ddd706228 100644 --- a/pages/content/amp-dev/documentation/guides-and-tutorials/index.html +++ b/pages/content/amp-dev/documentation/guides-and-tutorials/index.html @@ -181,5 +181,5 @@

Featured Videos

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}

Get Involved

-

AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.

+ AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.
diff --git a/pages/content/amp-dev/documentation/guides-and-tutorials/index.stories.html b/pages/content/amp-dev/documentation/guides-and-tutorials/index.stories.html index 98f3aead246..3b275c2847d 100644 --- a/pages/content/amp-dev/documentation/guides-and-tutorials/index.stories.html +++ b/pages/content/amp-dev/documentation/guides-and-tutorials/index.stories.html @@ -155,5 +155,5 @@

Featured Videos

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}

Get Involved

-

AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.

+ AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.
diff --git a/pages/content/amp-dev/documentation/guides-and-tutorials/index.websites.html b/pages/content/amp-dev/documentation/guides-and-tutorials/index.websites.html index 9daa1083a65..01ac1b45cb1 100644 --- a/pages/content/amp-dev/documentation/guides-and-tutorials/index.websites.html +++ b/pages/content/amp-dev/documentation/guides-and-tutorials/index.websites.html @@ -178,5 +178,5 @@

Featured Videos

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}

Get Involved

-

AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.

+ AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.
From 870e217f8b6e3a5cee422eff906fdc13a034cf72 Mon Sep 17 00:00:00 2001 From: "robin.van-opstal@jvm.de" Date: Mon, 8 Apr 2019 15:05:00 +0200 Subject: [PATCH 2/2] fix stylings for banner --- frontend/scss/base.scss | 2 +- frontend/scss/components/organisms/banner.scss | 3 +-- .../documentation/guides-and-tutorials/index.ads.html | 6 ++++-- .../documentation/guides-and-tutorials/index.email.html | 6 ++++-- .../amp-dev/documentation/guides-and-tutorials/index.html | 6 ++++-- .../documentation/guides-and-tutorials/index.stories.html | 6 ++++-- .../documentation/guides-and-tutorials/index.websites.html | 6 ++++-- 7 files changed, 22 insertions(+), 13 deletions(-) diff --git a/frontend/scss/base.scss b/frontend/scss/base.scss index 2a9ba2cf9ab..05410b0da55 100644 --- a/frontend/scss/base.scss +++ b/frontend/scss/base.scss @@ -12,7 +12,7 @@ html, body { padding: 0; margin: 0; min-width: 320px; - color: color('black'); + color: color('river-bed'); background-color: #fff; font-size: 16px; font-family: sans-serif; diff --git a/frontend/scss/components/organisms/banner.scss b/frontend/scss/components/organisms/banner.scss index 5b6fcdf5ddd..cfc0c5dda84 100644 --- a/frontend/scss/components/organisms/banner.scss +++ b/frontend/scss/components/organisms/banner.scss @@ -25,8 +25,7 @@ } .#{organism('banner')} { - &-headline, &-copy { - display: block; + &-headline, p { max-width: 720px; color: color('white'); } diff --git a/pages/content/amp-dev/documentation/guides-and-tutorials/index.ads.html b/pages/content/amp-dev/documentation/guides-and-tutorials/index.ads.html index 4df5788cc59..72fb60ddea3 100644 --- a/pages/content/amp-dev/documentation/guides-and-tutorials/index.ads.html +++ b/pages/content/amp-dev/documentation/guides-and-tutorials/index.ads.html @@ -154,6 +154,8 @@

Featured Videos

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}
-

Get Involved

- AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less. +
+

Get Involved

+

AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.

+
diff --git a/pages/content/amp-dev/documentation/guides-and-tutorials/index.email.html b/pages/content/amp-dev/documentation/guides-and-tutorials/index.email.html index 6f21487f4d9..eafec2be799 100644 --- a/pages/content/amp-dev/documentation/guides-and-tutorials/index.email.html +++ b/pages/content/amp-dev/documentation/guides-and-tutorials/index.email.html @@ -154,6 +154,8 @@

Featured Videos

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}
-

Get Involved

- AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less. +
+

Get Involved

+

AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.

+
diff --git a/pages/content/amp-dev/documentation/guides-and-tutorials/index.html b/pages/content/amp-dev/documentation/guides-and-tutorials/index.html index c2ddd706228..1c767dabec5 100644 --- a/pages/content/amp-dev/documentation/guides-and-tutorials/index.html +++ b/pages/content/amp-dev/documentation/guides-and-tutorials/index.html @@ -180,6 +180,8 @@

Featured Videos

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}
-

Get Involved

- AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less. +
+

Get Involved

+

AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.

+
diff --git a/pages/content/amp-dev/documentation/guides-and-tutorials/index.stories.html b/pages/content/amp-dev/documentation/guides-and-tutorials/index.stories.html index 3b275c2847d..56f4ef6840e 100644 --- a/pages/content/amp-dev/documentation/guides-and-tutorials/index.stories.html +++ b/pages/content/amp-dev/documentation/guides-and-tutorials/index.stories.html @@ -154,6 +154,8 @@

Featured Videos

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}
-

Get Involved

- AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less. +
+

Get Involved

+

AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.

+
diff --git a/pages/content/amp-dev/documentation/guides-and-tutorials/index.websites.html b/pages/content/amp-dev/documentation/guides-and-tutorials/index.websites.html index 01ac1b45cb1..eb2059f0cb8 100644 --- a/pages/content/amp-dev/documentation/guides-and-tutorials/index.websites.html +++ b/pages/content/amp-dev/documentation/guides-and-tutorials/index.websites.html @@ -177,6 +177,8 @@

Featured Videos

{% do doc.styles.addCssFile('/css/components/organisms/banner.css') %}
-

Get Involved

- AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less. +
+

Get Involved

+

AMP is proudly an open source project with an active community of contributors. We welcome and appreciate documentation and translation contributions! Check out our community section to join our mission to make the web suck less.

+