-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Star rating component #2691
Comments
Thanks for raising—this would be a good thing to do eventually. Slotting it in the backlog for now, but feel free to submit an intent to implement if you'd like to propose an approach. |
I should mention, though, that until we build out support for forms, the rating component won't be able to handle the actual input & transmission of data. Happy to see implementations for the ratings UI in the short term, but we won't see the full benefit until forms support is implemented. |
Forms were released to production on 2016-10-31. Holding off until these are released as well:
See also #5540. |
Closing for ampproject/amp-by-example#558 |
Re-opening since we decided (see ampproject/amp-by-example#558 (comment)) to make this an AMP component. @dandv I assume you are still willing to take this one. When you have the API you have in mind ready, let's do a quick forma review with the team. (Just a PR with an example usage and/or markdown file for the API should be enough for the review) |
@aghassemi @dandv FYI, bumped the priority on this up slightly, given how useful it is for a range of e-comm use cases — @dandv, do you have a sense of a timeframe for this component? |
Repasting my thoughts here @dandv - i just had a thought, I think it might be easy to build on top very easily It will make the component more semantic https://codepen.io/catharsis/pen/vquyj Let me know what you think ! (https://css-tricks.com/styling-cross-browser-compatible-range-inputs-css/) |
Sorry, been bogged down with other work. Hope to get back to this soon.
|
Thanks for the last update. Anything new happening with this? |
Now that I/O is over, I'm back to work on this since it can unblock a number of partners. /cc @joemarini FYI |
I have fixed the reverse arrow issue in Starability.css. Now it works with keyboard in correct order. You might consider that. https://github.com/LunarLogic/starability |
This issue hasn't been updated in awhile. @dandv Do you have any updates? |
p2 -> p3 since there is an ABE sample for it already. |
We'd love to use this feature and know of many users who would too. |
@nicopujol Have you had a chance to take a look at this guide for implementing star ratings in AMP: https://amp.dev/documentation/examples/interactivity-dynamic-content/star_rating/ ? It would be great to hear what kinds of use cases you think a dedicated component would address vs what's possible with the capabilities illustrated in the guide linked above. cc @nainar |
Hi @rudygalfi @nainar , Some thoughts:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
A star rating AMP HTML component would enable common 1-5 star rating displays, with optional input.
Prior art is documented in my comparison of star rating widgets.
The text was updated successfully, but these errors were encountered: