Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Story autoanalytics] Added repeat: false on story-page-visible #32296

Merged
merged 5 commits into from
Feb 9, 2021
Merged

✨ [Story autoanalytics] Added repeat: false on story-page-visible #32296

merged 5 commits into from
Feb 9, 2021

Conversation

mszylkowski
Copy link
Contributor

We want to trigger the page visible analytics only once for each page, so we set repeat: false

@mszylkowski mszylkowski self-assigned this Jan 29, 2021
gmajoulet
gmajoulet reviewed Jan 29, 2021
View reviewed changes
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it on the storyEnd too? Otherwise a user can go on the last page, navigate back and forward again to trigger a second storyEnd event

@mszylkowski mszylkowski requested a review from gmajoulet January 29, 2021 20:12
@mszylkowski mszylkowski merged commit 8a71a5d into ampproject:master Feb 9, 2021
@mszylkowski mszylkowski deleted the autoanalytics_repeat branch February 9, 2021 17:39
@mszylkowski mszylkowski mentioned this pull request Feb 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enriqe Enriqe Enriqe approved these changes

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees

@mszylkowski mszylkowski

Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mszylkowski @gmajoulet @Enriqe @ampprojectbot