Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed release workflow completely #882

Merged
merged 28 commits into from
Jan 28, 2021
Merged

fix: changed release workflow completely #882

merged 28 commits into from
Jan 28, 2021

Conversation

allisonsuarez
Copy link
Contributor

Summary of Changes

https://github.com/peter-evans/create-pull-request#action-inputs

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

@allisonsuarez
added PR creation to release action
a84e9a7 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
set new branch rather than master
17b0a27 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
changed cron to 12:15pm
4fe9ab5 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
chnaged release aciton branch and added manual run trigger
b63a8be 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
resolved merge conflicts
43f607e 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
eventually I'll get this right...
9063fcb 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
forgot to pull again
27137d4 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
another one
a03facf 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
one more branch change
bcdbbdb 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
fingers crossed on this one
9374ac0 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
trying to get the branch there so it can be checked out
a9d916c 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
Merge branch 'master' of github.com:amundsen-io/amundsenfrontendlibra…
3dff7c5 
…ry into asm-release-auto-pr
@allisonsuarez
added pypy credentials
5041343 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
Merge branch 'master' of github.com:amundsen-io/amundsenfrontendlibra…
60514b5 
…ry into asm-release-auto-pr
@allisonsuarez
Merge branch 'master' of github.com:amundsen-io/amundsenfrontendlibra…
b515916 
…ry into asm-release-auto-pr
@allisonsuarez
chaged to uses/with
dc2b946 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
bumped version on setup.py file
622b79b 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
Merge branch 'master' of github.com:amundsen-io/amundsenfrontendlibra…
bfae735 
…ry into asm-release-auto-pr
@allisonsuarez
Merge branch 'master' of github.com:amundsen-io/amundsenfrontendlibra…
bd30ee7 
…ry into asm-release-auto-pr
@allisonsuarez
added pypi user and pass
bbec346 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
Merge branch 'master' of github.com:amundsen-io/amundsenfrontendlibra…
7be856c 
…ry into asm-release-auto-pr
@allisonsuarez
setting base branch to be master
08bc2ab 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez requested a review from a team as a code owner January 21, 2021 20:25
@allisonsuarez
delete branch after pr closed
3cf7783 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez marked this pull request as draft January 21, 2021 20:41
@allisonsuarez allisonsuarez marked this pull request as ready for review January 21, 2021 22:27
feng-tao
feng-tao reviewed Jan 21, 2021
View reviewed changes
.github/workflows/monthly_release.yml
@@ -41,3 +41,5 @@ jobs:

[1]: https://github.com/peter-evans/create-pull-request
branch: new-release
base: master
delete-branch: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: what does delete branch do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletes the branch new-release in this case. Right now I am looking into weather the python-semantic-release action requires the branch to already be exist or if it can checkout a ew branch.

@allisonsuarez
Merge branch 'master' of github.com:amundsen-io/amundsenfrontendlibra…
83d7370 
…ry into asm-release-auto-pr
@allisonsuarez
trying a different more granular approach, pypi should be triggered o…
b475407 
…nce PR with new version is merged

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
publishes new release
f6f1f25 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
fixed
d7fd395 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
hoping this works, will add changelog next if it does
03e88a8 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez changed the title fix: added base branch for release workflow fix: changed release workflow completely Jan 28, 2021
dikshathakur3119
dikshathakur3119 approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@dikshathakur3119 dikshathakur3119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@allisonsuarez allisonsuarez merged commit 5dfcd09 into master Jan 28, 2021
@allisonsuarez allisonsuarez deleted the asm-release-auto-pr branch January 28, 2021 21:59
@github-actions github-actions bot mentioned this pull request Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

@feng-tao feng-tao feng-tao approved these changes

@dikshathakur3119 dikshathakur3119 dikshathakur3119 approved these changes

@dorianj dorianj Awaiting requested review from dorianj

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@allisonsuarez @Golodhros @feng-tao @dikshathakur3119