Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add changelog file #907

Merged
merged 8 commits into from
Feb 1, 2021
Merged

fix: add changelog file #907

merged 8 commits into from
Feb 1, 2021

Conversation

allisonsuarez
Copy link
Contributor

@allisonsuarez allisonsuarez commented Feb 1, 2021

Summary of Changes

Added CHANGELOG.md file to persist the changes from the new release, as well as preventing a new release from happening if the setup.py file is changed without a version bump. Release publishing should be triggered when both setup.py and CHANGELOG.md have been changed.
CHANGELOG.md should be overwritten every time and only contain the changes in the newest release.

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

semantic-release and others added 5 commits January 28, 2021 17:22
Automatically generated by python-semantic-release
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez requested a review from a team as a code owner February 1, 2021 19:57
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez merged commit f06c50e into master Feb 1, 2021
@allisonsuarez allisonsuarez deleted the asm-finetune-release branch February 1, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants