fix _ion_writer_add_annotation_helper memory accumulation #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgregg
reviewed
May 31, 2022
There was a problem hiding this comment.
Thanks for the contribution!
Although this is technically a behavioral change (before, the user could safely free the provided ION_STRING immediately after calling this function; now, that is unsafe), I'm okay with it as I think it's unlikely anyone would be doing that. It also follows the same pattern as ion_writer_write_field_name*.
One request: could you please add a comment to this API stating this requirement. See the comment on ion_writer_write_field_name, for example.
tgregg
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.