Fix reader, stream, and import leaks in CLI #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion_cli_open_writer was not setting the writer context's has_imports to true after adding shared imports, which resulted in the imports not being closed when the writer was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None
Description of changes:
Minor fixes to release memory in two spots within cli.cpp.
The first was when opening a writer via
ion_cli_open_writerwith imports, thehas_importsflag would not be set on the writer context, resulting in leaked imports fromion_event_writer_closenot closing the imports.The second is a stream and reader leak when cleaning up the reader_contexts in
ion_cli_command_compare_standard.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.