Fix a couple leaks around event and symbol cleanup #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, ion_event_stream_read_event did not completely clean up the internal string data for annotation symbols (name and import_location) and the current p_value_field_name.
|
test-driver failed due to different line number, |
tgregg
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None
Description of changes:
This PR addresses two instances in ion_event_stream where leaks were occurring.
The first is when cleaning up the annotation symbols, and field name, at the end of
ion_event_stream_read_event. The string data forvalue_field_name, as well as each of the symbols stored invalue_annotationswas not freed.The second was when removing an event from the event stream in
ion_event_stream_is_event_stream. Once the pointer to the event is removed from the vector, the object itself needed to be freed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.