You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In replit, the crc32 package returns CRC32 checksum instead of CRC32C checksum
Expected behavior
The benchmarking of CRC32C checksum by sse4_crc32 should be done against another pure-JS CRC32C checksum implementation like junderw-crc32c and not crc32
The text was updated successfully, but these errors were encountered:
trivikr
changed the title
Benchmarking should be done with CRC32C implementations and not CRC32 implementation
Benchmark with CRC32C implementations and not CRC32 implementation
Apr 27, 2021
trivikr
changed the title
Benchmark with CRC32C implementations and not CRC32 implementation
Benchmark with pure-JS CRC32C implementations
Apr 27, 2021
Describe the bug
The benchmarking is done against pure JS CRC32 implementation, although it calls it CRC32C
sse4_crc32/benchmark/single_fixed_size_buffer.benchmark.js
Lines 44 to 50 in 15cf479
Steps to reproduce
replit https://replit.com/@trivikr/test-sse4crc32-benchmark
Online CRC32 calculator https://crccalc.com/?crc=123456789&method=crc32&datatype=ascii&outtype=hex
Code
Observed behavior
In replit, the
crc32
package returns CRC32 checksum instead of CRC32C checksumExpected behavior
The benchmarking of
CRC32C
checksum bysse4_crc32
should be done against another pure-JS CRC32C checksum implementation likejunderw-crc32c
and notcrc32
Additional context
I noticed this while writing my own CRC32 benchmark in https://github.com/trivikr/benchmark-crc32
The text was updated successfully, but these errors were encountered: