INTERNACION - Ordenar la tabla por columna #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquid36
requested changes
Aug 11, 2020
| sortTable(event: string) { | ||
| if (this.sortBy === event) { | ||
| this.sortOrder = (this.sortOrder === 'asc') ? 'desc' : 'asc'; | ||
| this.camas = this.camas.pipe( |
There was a problem hiding this comment.
Más allá de la discución si esto va en el servicies o no, cada vez que se ordena crear un nuevo Observable. Desconosco como lo handlea Angular esto, pero pueden quedar subscripciones sueltas.
sortBy y sortOrder deberían ser BehaviorSubject y unir todo con combineLastest.
Además mantenemos el mismo criterio que los filtros por ejemplo.
liquid36
approved these changes
Aug 18, 2020
| @@ -2,3 +2,7 @@ | |||
| color: white; | |||
| background-color: #002738 !important; | |||
| } | |||
|
|
|||
| table tr th.sortable:hover { | |||
| text-decoration: underline !important; | |||
There was a problem hiding this comment.
UI/UX
agregar cursor: pointer;
silviroa
approved these changes
Aug 27, 2020
liquid36
pushed a commit
that referenced
this pull request
Sep 2, 2020
# [5.11.0](v5.10.0...v5.11.0) (2020-09-02) ### Bug Fixes * **mapa-camas:** missing DragAndDrop service ([#1890](#1890)) ([011fc4b](011fc4b)) * **mapa-camas:** no se visualiza la huds ([#1881](#1881)) ([0e5a85c](0e5a85c)) * **rup:** filtrar valores null de los graficos ([#1846](#1846)) ([cdf5786](cdf5786)) * **TOP:** remueve condicion tieneTurno de busqueda de validadas ([#1867](#1867)) ([76174a3](76174a3)) ### Features * **elemento-rup:** filtro por sexo en requeridos ([#1828](#1828)) ([8fe206c](8fe206c)) * **elementos-rup:** elimina atomos y moléculas que no deberían existir ([#1856](#1856)) ([63b9b29](63b9b29)) * **gdu:** permitir copy/paste entre prestaciones ([#1878](#1878)) ([3471f50](3471f50)) * **mapa-camas:** permite ordenar por columna ([#1851](#1851)) ([a933596](a933596)) * **mpi:** muestra direccion legal del paciente ([#1876](#1876)) ([be39e08](be39e08)) * **organizaciones:** disable eliminar UO que esta en uso en una cama ([#1770](#1770)) ([8857b42](8857b42)) * **rup:** asistencia del turno en background ([#1788](#1788)) ([3d8f2d4](3d8f2d4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requerimiento
Poder ordenar las columnas del listado del mapa de cama. Así puede decidir si quiero agrupar por sector, unidar organizativa, estados, etc. Le da más poder de decisión al usuario.
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion