fix(MISC-166): Bug al cargar numero de carpeta a un paciente #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquid36
reviewed
Jul 13, 2021
| @@ -36,8 +38,8 @@ | |||
| </plex-badge> | |||
| </ng-container> | |||
| <plex-wrapper class="w-100" *ngIf="!showList"> | |||
| <plex-text label="Nuevo número de Carpeta" name="nroCarpeta" [(ngModel)]="nuevoNroCarpeta"> | |||
| </plex-text> | |||
| <plex-int label="Nuevo número de Carpeta" name="nroCarpeta" [(ngModel)]="nuevoNroCarpeta"> | |||
There was a problem hiding this comment.
No todos los números de carpeta son numéricos, algunas arrancan con letras XD
MarianoCampetella
force-pushed
the
MISC-166
branch
from
234fd2e
to
a0207ab
Compare
liquid36
reviewed
Jul 19, 2021
| if (this.indiceCarpeta > -1) { | ||
| this.carpetaEfectores[this.indiceCarpeta] = this.carpetaPaciente; | ||
| if (/^\s*$/.test(this.nuevoNroCarpeta)) { | ||
| this.plex.info('warning', '', 'Ingrese un número de carpeta válido'); |
There was a problem hiding this comment.
Cuando hago click en guardar con un espacio en blanco, me aparece le modal correctamente. Pero paso seguido me saca de la edición de la carpeta. Debería quedarse en el formulario de alta. Eso se corrige con un return preventivo
Suggested change
| this.plex.info('warning', '', 'Ingrese un número de carpeta válido'); | |
| this.plex.info('warning', '', 'Ingrese un número de carpeta válido'); | |
| return; |
Yo cambiaría el modal por un toas además.
Y a futuro lo mejor sería usar validación de formularios así el campo se marca en rojito pero no existe eso en esta pantalla todavía.
MarianoCampetella
force-pushed
the
MISC-166
branch
from
8c8f3bb
to
ea65429
Compare
MarianoCampetella
force-pushed
the
MISC-166
branch
from
ea65429
to
e17d506
Compare
liquid36
approved these changes
Jul 19, 2021
liquid36
pushed a commit
that referenced
this pull request
Jul 21, 2021
# [5.56.0](v5.55.0...v5.56.0) (2021-07-21) ### Bug Fixes * **citas:** bug al cargar numero de carpeta a un paciente ([#2367](#2367)) ([30a745e](30a745e)) * **COM:** color prioridad intermedia ([#2375](#2375)) ([718e43a](718e43a)) * **inscripcion:** modifica rango edad de FR ([#2376](#2376)) ([62e16fb](62e16fb)) ### Features * **buscador-ficha:** filtro tipoConfirmacion + collapse ([0bcb9c2](0bcb9c2)) * **EP:** resize sidebar paciente ([27fa2ca](27fa2ca)) * **ficha:** Agregamos filtro por clasificación ([f074306](f074306)) * **ficha:** filtro clasificacion ([fae3dd2](fae3dd2)) * **ficha-epidemio:** caso asintomatico ([#2368](#2368)) ([235b062](235b062)) * **ficha-epidemio:** regex pcr ([5f69450](5f69450)) * **mapa-camas:** agrega atributo esCensable al esquema de prestacion ([#2335](#2335)) ([03ad569](03ad569)) * **mpi:** seteo de atributos en paciente-detalle ([#2354](#2354)) ([af52e84](af52e84)) * **rup:** nueva coleccion prestaciones historial ([#2369](#2369)) ([1fca8ea](1fca8ea))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/MISC-166
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion