-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOP (Fix) - Eliminación de ultima regla #2537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onSave($event) { | ||
if (this.reglas?.length) { | ||
save() { | ||
if (this.reglas.length) { | ||
if (this.reglaCorrecta) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Estaría bueno acomodar el código, verificarRegla debería devolver un booleano en vez de asignar una variable para su posterior uso. Ver todos los lugares donde se usa.
if (this.reglaCorrecta) { | |
if (this.verificarRegla()) { |
<plex-list *ngFor="let prestacion of regla.origen.prestaciones; let i=index" size="sm" (click)="activarPrestacion(i)"> | ||
<plex-item> | ||
<plex-grid cols="2" size="sm" justify="around" class="mt-0 pt-0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plex-grid
no va a dentro de un plex-item
. Qué problema tuviste?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Podes usar un ngProjectAs="plex-label"
para acomodarlo segundo. Fuera de ese truco estaría bueno saber que opina @andrrrl @AgosLizzi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coincido con @liquid36! Adjunto snippet para que el contenido del item quede alineado y el título de la prestación capitalizado:
<plex-item case="capitalize">
<plex-label *ngIf="prestacion.prestacion?.term" titulo="{{ prestacion.prestacion.term }}"
[tituloBold]="false" subtitulo=""></plex-label>
<plex-bool ngProjectAs="plex-label" [(ngModel)]="prestacion.auditable" name="prestacionAuditable{{i}}"
label="Auditable" class="mb-1">
</plex-bool>
<plex-button icon="delete" type="danger" size="sm" (click)="deletePrestacion(i)">
</plex-button>
</plex-item>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excelenteee. Corregido!
@liquid36 se agregó también un control/aviso para cuando se borraron las reglas existentes (No hay organización origen).
se actualiza además el uso de componentes plex en el template
# [5.77.0](v5.76.0...v5.77.0) (2021-12-15) ### Bug Fixes * **citas:** frecuentes duplicados ([#2547](#2547)) ([ca84c09](ca84c09)) * **top:** eliminacion de ultima regla ([#2537](#2537)) ([ddb2104](ddb2104)) ### Features * **CIT:** refactor visual header dar turno ([#2543](#2543)) ([b274c33](b274c33)) * **mapa-camas:** mostrar registro de diagnostico al ingreso ([#2529](#2529)) ([fb02b8c](fb02b8c)) * **misc:** visualizacion de las matriculas de un profesional ([#2540](#2540)) ([c0c6de1](c0c6de1)) * **tm:** refactor pantalla organizaciones ([#2528](#2528)) ([33e05e8](33e05e8))
se actualiza además el uso de componentes plex en el template
Requerimiento
https://proyectos.andes.gob.ar/browse/TOP-121
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion