Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

vertical scrolling neccessary on Galaxy Tab S2 in Chroma-Key-Editing #139

Closed
danielh84 opened this issue Nov 21, 2020 · 7 comments
Closed
Labels
bug Something isn't working stale

Comments

@danielh84
Copy link

Describe the bug
With the Galaxy Tab S2 (1024x762, Device-Pixel-Ratio:2) you get an vertical scrollbar by editing pictures with chroma key (chromakeying.php?filename=20201121_125652.jpg). Maybe the main picture should be smaller to get everything on the tablet without scrolling. You cant see the "save" and "close" buttons without scrolling:
grafik

To Reproduce
Steps to reproduce the behavior:

  1. Use Ratio of the Galaxy Tab S2
  2. Go to "Gallery" and use "Chroma Key"-Button
  3. See error

Expected behavior
You have to see the save and close Buttons without scrolling.

Environment (please complete the following information):

  • Android
  • Fully Kiosk Browser

Photobooth

  • Which version of Photobooth are you using? -> Develop-branch 21.11.2020
@danielh84 danielh84 added the bug Something isn't working label Nov 21, 2020
@andi34
Copy link
Owner

andi34 commented Dec 3, 2020

Hey and sorry for the late reply.

You can try to lower the width here:

.canvasWrapper {
width: 1000px;
display: inline-block;
max-width: 100%;
background-color: green;
border: 4px solid $borderColor;
}

@danielh84
Copy link
Author

width: 850px; works fine with this device.

i will try to find a css-config that it will fit to all resolutions. maybe there is a good opinion.

@andi34
Copy link
Owner

andi34 commented Dec 7, 2020

Something like

@media (max-height: 765px) {
  .canvasWrapper {
    width: 850px;
  }
}

Maybe?

@andi34 andi34 mentioned this issue Dec 19, 2020
2 tasks
@andi34
Copy link
Owner

andi34 commented Dec 19, 2020

@danielh84 can you try from feature/livekeying branch?

@danielh84
Copy link
Author

no, does not work. Tested with classic and modern styling

@andi34
Copy link
Owner

andi34 commented Jan 28, 2021

After #159 you're allowed to use your custom style

Needs all of them to work (can be copy of existing files):

template/custom.template.php
resources/css/custom_style.css
resources/css/custom_chromakeying.css
resources/css/custom_live_chromakeying.css

@andi34
Copy link
Owner

andi34 commented Feb 28, 2021

Any progress on the css changes to not affect all resolutions?

@andi34 andi34 added the stale label Mar 21, 2021
@andi34 andi34 closed this as completed Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants