Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkPhase = false always #12

Open
dzmitry-lahoda opened this issue Nov 8, 2023 · 3 comments
Open

checkPhase = false always #12

dzmitry-lahoda opened this issue Nov 8, 2023 · 3 comments

Comments

@dzmitry-lahoda
Copy link

I see 1.0 had enabled checkPhase of Polkadot (other codes?).

And then disabled because of issue.

doCheck = false;

Could we have all tests always disabled, assuming check happens by CI?

This will speed up builds

@dzmitry-lahoda
Copy link
Author

or alternatively do this #10

@andresilva
Copy link
Owner

Could we have all tests always disabled, assuming check happens by CI?

I am not sure what you mean here. Do you mean keep doCheck = false forever as it is now? Or do it for all the other packages?

@dzmitry-lahoda
Copy link
Author

all false forever for all packages. i see now idea to enable true again on polkadot, imho that is not required for releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants