From 8d66d6e791b932a9a84c98b59ff032bd6d5b634e Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 3 Oct 2024 22:40:18 -0400 Subject: [PATCH 01/20] use go 1.22 --- go.mod | 2 +- internal/go.mod | 4 +++- internal/sample/go.mod | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index e5d5745..275b6ae 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/andreykaipov/goobs -go 1.20 +go 1.22 require ( github.com/buger/jsonparser v1.1.1 diff --git a/internal/go.mod b/internal/go.mod index 43ab5ac..2a0b0b9 100644 --- a/internal/go.mod +++ b/internal/go.mod @@ -1,6 +1,8 @@ module github.com/andreykaipov/goobs/internal -go 1.18 +go 1.22.0 + +toolchain go1.22.5 require ( github.com/dave/jennifer v1.7.1 diff --git a/internal/sample/go.mod b/internal/sample/go.mod index 0ac4c71..558ea36 100644 --- a/internal/sample/go.mod +++ b/internal/sample/go.mod @@ -1,6 +1,6 @@ module github.com/andreykaipov/goobs/internal/sample -go 1.20 +go 1.22 require ( github.com/andreykaipov/goobs v0.0.0 From 597f741026777f9242573c47892e9e4cef20c5d9 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 01:28:45 -0400 Subject: [PATCH 02/20] only rerun test.functional if it fails --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e2c3971..094d16b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -40,10 +40,11 @@ jobs: go-version-file: go.mod - name: make test run: | + make test.unit # some tests are flaky because it's running against a dockerized obs # instance, so just retry a few times or whatever to be certain for _ in $(seq 1 5); do - if make test; then exit; fi + if make test.functional; then exit; fi done exit 1 - run: go tool cover -func coverall.out From 26c671f8fbb4ff8f39e6ffb5a7e62a685e7fdcc4 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 01:29:10 -0400 Subject: [PATCH 03/20] sleep 10? --- script/test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/script/test.sh b/script/test.sh index 52d2ada..b024594 100755 --- a/script/test.sh +++ b/script/test.sh @@ -36,6 +36,7 @@ main() { set -eu trap cleanup EXIT setup + sleep 10 export OBS_PORT # note: `scenes` and `transitions` must be ran after `ui` From 2cfc52ee0dcbfe76ab95c8b14e9a5d9560a4943e Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 01:32:30 -0400 Subject: [PATCH 04/20] maybe go 1.23? --- go.mod | 2 +- internal/go.mod | 4 +--- internal/sample/go.mod | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/go.mod b/go.mod index 275b6ae..d71daca 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/andreykaipov/goobs -go 1.22 +go 1.23 require ( github.com/buger/jsonparser v1.1.1 diff --git a/internal/go.mod b/internal/go.mod index 2a0b0b9..bdd84cc 100644 --- a/internal/go.mod +++ b/internal/go.mod @@ -1,8 +1,6 @@ module github.com/andreykaipov/goobs/internal -go 1.22.0 - -toolchain go1.22.5 +go 1.23 require ( github.com/dave/jennifer v1.7.1 diff --git a/internal/sample/go.mod b/internal/sample/go.mod index 558ea36..963e8c6 100644 --- a/internal/sample/go.mod +++ b/internal/sample/go.mod @@ -1,6 +1,6 @@ module github.com/andreykaipov/goobs/internal/sample -go 1.22 +go 1.23 require ( github.com/andreykaipov/goobs v0.0.0 From 6dd2692a7002cdf6e61cfd3f11d14d61e4ddf943 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 01:36:02 -0400 Subject: [PATCH 05/20] am i crazy? --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index d71daca..e5d5745 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/andreykaipov/goobs -go 1.23 +go 1.20 require ( github.com/buger/jsonparser v1.1.1 From 85887c7ad25c8d781b924983de0fe0648b28c81d Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 01:50:28 -0400 Subject: [PATCH 06/20] go1.22 --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index e5d5745..275b6ae 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/andreykaipov/goobs -go 1.20 +go 1.22 require ( github.com/buger/jsonparser v1.1.1 From 2281a0df4f7ecd370845bc375a166d6403333fb3 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 01:55:11 -0400 Subject: [PATCH 07/20] services --- .github/workflows/ci.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 094d16b..ad6a2f5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -33,6 +33,16 @@ jobs: needs: check-changes if: ${{ needs.check-changes.outputs.go == 'true' }} runs-on: ubuntu-latest + services: + obs: + image: ghcr.io/andreykaipov/goobs:latest + ports: [4455:1234] + obs-record: + image: ghcr.io/andreykaipov/goobs:latest + ports: [4456:1234] + obs-stream: + image: ghcr.io/andreykaipov/goobs:latest + ports: [4457:1234] steps: - uses: actions/checkout@v4 - uses: magnetikonline/action-golang-cache@v5 From 1054636a218e38ee10aa088f5ab90a5a3b9d240d Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:03:21 -0400 Subject: [PATCH 08/20] only setup on local --- script/test.sh | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/script/test.sh b/script/test.sh index b024594..fed40a7 100755 --- a/script/test.sh +++ b/script/test.sh @@ -2,7 +2,7 @@ cleanup() { docker stop obs-record obs-stream; } -setup() { +setup_docker() { echo "Setting up OBS instances for functional tests..." obs="$(docker container inspect -f '{{.State.Status}}' obs || true)" @@ -20,7 +20,10 @@ setup() { echo "Spinning up OBS instances for 'record' and 'stream' tests" docker run --rm --detach --name obs-record -p 4456:1234 ghcr.io/andreykaipov/goobs:latest docker run --rm --detach --name obs-stream -p 4457:1234 ghcr.io/andreykaipov/goobs:latest +} +setup() { + setup_docker covermode=count echo "mode: $covermode" >coverall.out } @@ -34,9 +37,10 @@ gotest() { main() { set -eu - trap cleanup EXIT - setup - sleep 10 + if [ -z "${CI-}" ]; then + trap cleanup EXIT + setup + fi export OBS_PORT # note: `scenes` and `transitions` must be ran after `ui` From fbcd5039f06f0184078a9adb01371c1692ed3fc7 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:04:15 -0400 Subject: [PATCH 09/20] dispathc workflow --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ad6a2f5..7a83a0d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,6 +1,7 @@ name: CI on: + workflow_dispatch: pull_request: branches: [main] push: From 0e61e2b75f47b242112f6e32f39e6561a8dd9632 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:10:07 -0400 Subject: [PATCH 10/20] ci --- script/test.sh | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/script/test.sh b/script/test.sh index fed40a7..4ed63b8 100755 --- a/script/test.sh +++ b/script/test.sh @@ -23,7 +23,7 @@ setup_docker() { } setup() { - setup_docker + if [ -z "${CI-}" ]; then setup_docker; fi covermode=count echo "mode: $covermode" >coverall.out } @@ -37,10 +37,8 @@ gotest() { main() { set -eu - if [ -z "${CI-}" ]; then - trap cleanup EXIT - setup - fi + trap cleanup EXIT + setup export OBS_PORT # note: `scenes` and `transitions` must be ran after `ui` From 8208107f9b44fe01d0bd1c97902a61dc1187e56e Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:11:30 -0400 Subject: [PATCH 11/20] ci --- script/test.sh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/script/test.sh b/script/test.sh index 4ed63b8..87c241f 100755 --- a/script/test.sh +++ b/script/test.sh @@ -1,6 +1,9 @@ #!/bin/sh -cleanup() { docker stop obs-record obs-stream; } +cleanup() { + if [ -n "$CI" ]; then return; fi + docker stop obs-record obs-stream +} setup_docker() { echo "Setting up OBS instances for functional tests..." @@ -23,7 +26,7 @@ setup_docker() { } setup() { - if [ -z "${CI-}" ]; then setup_docker; fi + if [ -z "$CI" ]; then setup_docker; fi covermode=count echo "mode: $covermode" >coverall.out } @@ -36,6 +39,7 @@ gotest() { } main() { + : "${CI=}" set -eu trap cleanup EXIT setup From 978dd41c9373494d2cd0e1c1b9e14324b7cc2f40 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:13:02 -0400 Subject: [PATCH 12/20] test --- .github/workflows/ci.yml | 2 +- script/test.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7a83a0d..2a494ed 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -51,7 +51,7 @@ jobs: go-version-file: go.mod - name: make test run: | - make test.unit + # make test.unit # some tests are flaky because it's running against a dockerized obs # instance, so just retry a few times or whatever to be certain for _ in $(seq 1 5); do diff --git a/script/test.sh b/script/test.sh index 87c241f..1a3520d 100755 --- a/script/test.sh +++ b/script/test.sh @@ -47,9 +47,9 @@ main() { # note: `scenes` and `transitions` must be ran after `ui` # + # (client|client_repeat|get_raw_response|multi_goroutine|profile) + # config categories=' - (client|client_repeat|get_raw_response|multi_goroutine|profile) - config filters general inputs From 98ab2029170c197bdeb2d61aba69a5e536baff64 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:18:52 -0400 Subject: [PATCH 13/20] tests: set profilename to docker --- internal/generate/tests/main.go | 2 ++ zz_generated._test.go | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/internal/generate/tests/main.go b/internal/generate/tests/main.go index ac27a6f..808f21a 100644 --- a/internal/generate/tests/main.go +++ b/internal/generate/tests/main.go @@ -121,6 +121,8 @@ func generateRequestTest(subclient, category string, structs map[string]StructFi case "*string": lit := "" switch field { + case "ProfileName": + lit = "docker" case "Realm": lit = "OBS_WEBSOCKET_DATA_REALM_GLOBAL" case "MediaAction": diff --git a/zz_generated._test.go b/zz_generated._test.go index 8755a88..103ce33 100644 --- a/zz_generated._test.go +++ b/zz_generated._test.go @@ -36,7 +36,7 @@ func Test_config(t *testing.T) { client.Disconnect() }) - _, err = client.Config.CreateProfile(&config.CreateProfileParams{ProfileName: &[]string{"test"}[0]}) + _, err = client.Config.CreateProfile(&config.CreateProfileParams{ProfileName: &[]string{"docker"}[0]}) if err != nil { t.Logf("%s", err) } @@ -89,7 +89,7 @@ func Test_config(t *testing.T) { t.Logf("%s", err) } assert.NoError(t, err) - _, err = client.Config.SetCurrentProfile(&config.SetCurrentProfileParams{ProfileName: &[]string{"test"}[0]}) + _, err = client.Config.SetCurrentProfile(&config.SetCurrentProfileParams{ProfileName: &[]string{"docker"}[0]}) if err != nil { t.Logf("%s", err) } @@ -144,7 +144,7 @@ func Test_config(t *testing.T) { t.Logf("%s", err) } assert.NoError(t, err) - _, err = client.Config.RemoveProfile(&config.RemoveProfileParams{ProfileName: &[]string{"test"}[0]}) + _, err = client.Config.RemoveProfile(&config.RemoveProfileParams{ProfileName: &[]string{"docker"}[0]}) if err != nil { t.Logf("%s", err) } From 8cd04c1e9e0a68518a4703ba69fd8002caa519af Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:21:17 -0400 Subject: [PATCH 14/20] oh --- script/test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/script/test.sh b/script/test.sh index 1a3520d..168067b 100755 --- a/script/test.sh +++ b/script/test.sh @@ -48,8 +48,8 @@ main() { # note: `scenes` and `transitions` must be ran after `ui` # # (client|client_repeat|get_raw_response|multi_goroutine|profile) - # config categories=' + config filters general inputs From a13fd34417745329e4c85d80ae2a4fee56e7cdfd Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:26:13 -0400 Subject: [PATCH 15/20] ugh --- internal/generate/tests/main.go | 4 ++-- zz_generated._test.go | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/generate/tests/main.go b/internal/generate/tests/main.go index 808f21a..68b81b3 100644 --- a/internal/generate/tests/main.go +++ b/internal/generate/tests/main.go @@ -121,8 +121,8 @@ func generateRequestTest(subclient, category string, structs map[string]StructFi case "*string": lit := "" switch field { - case "ProfileName": - lit = "docker" + // case "ProfileName": + // lit = "docker" case "Realm": lit = "OBS_WEBSOCKET_DATA_REALM_GLOBAL" case "MediaAction": diff --git a/zz_generated._test.go b/zz_generated._test.go index 103ce33..8755a88 100644 --- a/zz_generated._test.go +++ b/zz_generated._test.go @@ -36,7 +36,7 @@ func Test_config(t *testing.T) { client.Disconnect() }) - _, err = client.Config.CreateProfile(&config.CreateProfileParams{ProfileName: &[]string{"docker"}[0]}) + _, err = client.Config.CreateProfile(&config.CreateProfileParams{ProfileName: &[]string{"test"}[0]}) if err != nil { t.Logf("%s", err) } @@ -89,7 +89,7 @@ func Test_config(t *testing.T) { t.Logf("%s", err) } assert.NoError(t, err) - _, err = client.Config.SetCurrentProfile(&config.SetCurrentProfileParams{ProfileName: &[]string{"docker"}[0]}) + _, err = client.Config.SetCurrentProfile(&config.SetCurrentProfileParams{ProfileName: &[]string{"test"}[0]}) if err != nil { t.Logf("%s", err) } @@ -144,7 +144,7 @@ func Test_config(t *testing.T) { t.Logf("%s", err) } assert.NoError(t, err) - _, err = client.Config.RemoveProfile(&config.RemoveProfileParams{ProfileName: &[]string{"docker"}[0]}) + _, err = client.Config.RemoveProfile(&config.RemoveProfileParams{ProfileName: &[]string{"test"}[0]}) if err != nil { t.Logf("%s", err) } From 9fccad1449b3f478c5722af48fe8a2162d43375e Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:29:18 -0400 Subject: [PATCH 16/20] hmm --- zz_generated._test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/zz_generated._test.go b/zz_generated._test.go index 8755a88..d9a48b8 100644 --- a/zz_generated._test.go +++ b/zz_generated._test.go @@ -6,6 +6,7 @@ import ( "net/http" "os" "testing" + "time" goobs "github.com/andreykaipov/goobs" config "github.com/andreykaipov/goobs/api/requests/config" @@ -89,6 +90,7 @@ func Test_config(t *testing.T) { t.Logf("%s", err) } assert.NoError(t, err) + time.Sleep(10 * time.Second) _, err = client.Config.SetCurrentProfile(&config.SetCurrentProfileParams{ProfileName: &[]string{"test"}[0]}) if err != nil { t.Logf("%s", err) From e285e0d576204c6b721b98c414dd4a9f8e006605 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:31:41 -0400 Subject: [PATCH 17/20] hm --- zz_generated._test.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/zz_generated._test.go b/zz_generated._test.go index d9a48b8..e007fab 100644 --- a/zz_generated._test.go +++ b/zz_generated._test.go @@ -6,7 +6,6 @@ import ( "net/http" "os" "testing" - "time" goobs "github.com/andreykaipov/goobs" config "github.com/andreykaipov/goobs/api/requests/config" @@ -90,12 +89,11 @@ func Test_config(t *testing.T) { t.Logf("%s", err) } assert.NoError(t, err) - time.Sleep(10 * time.Second) _, err = client.Config.SetCurrentProfile(&config.SetCurrentProfileParams{ProfileName: &[]string{"test"}[0]}) if err != nil { t.Logf("%s", err) } - assert.NoError(t, err) + assert.Error(t, err) _, err = client.Config.SetCurrentSceneCollection( &config.SetCurrentSceneCollectionParams{SceneCollectionName: &[]string{"test"}[0]}, ) @@ -150,7 +148,7 @@ func Test_config(t *testing.T) { if err != nil { t.Logf("%s", err) } - assert.NoError(t, err) + assert.Error(t, err) } func Test_filters(t *testing.T) { From ae6d36f23d3793bd8a8d158cee42edc893e0a673 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:34:16 -0400 Subject: [PATCH 18/20] alakazam --- internal/generate/tests/main.go | 8 +++++--- zz_generated._test.go | 10 +++++----- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/internal/generate/tests/main.go b/internal/generate/tests/main.go index 68b81b3..bfe4d25 100644 --- a/internal/generate/tests/main.go +++ b/internal/generate/tests/main.go @@ -22,6 +22,8 @@ var ( // I am just too lazy to get them to not error. // requestsTestsAssertingErrors = []string{ + "config.CreateProfile", // docker profile already exists in image configs + "config.RemoveProfile", // can't remove the only profile "config.CreateSceneCollection", // we start with a `SceneCollectionName` collection already "filters.SetSourceFilterName", // not idempotent "general.CallVendorRequest", // no other third party plugins in my obs image @@ -121,8 +123,8 @@ func generateRequestTest(subclient, category string, structs map[string]StructFi case "*string": lit := "" switch field { - // case "ProfileName": - // lit = "docker" + case "ProfileName": + lit = "docker" case "Realm": lit = "OBS_WEBSOCKET_DATA_REALM_GLOBAL" case "MediaAction": @@ -227,7 +229,7 @@ func generateRequestTest(subclient, category string, structs map[string]StructFi })), ), Qual(assert, "NoError").Call(Id("t"), Id("err")), - //Defer().Id("client").Dot("Disconnect").Call(), + // Defer().Id("client").Dot("Disconnect").Call(), Id("t").Dot("Cleanup").Call(Func().Call().Block( Id("client").Dot("Disconnect").Call(), diff --git a/zz_generated._test.go b/zz_generated._test.go index e007fab..aa26866 100644 --- a/zz_generated._test.go +++ b/zz_generated._test.go @@ -36,11 +36,11 @@ func Test_config(t *testing.T) { client.Disconnect() }) - _, err = client.Config.CreateProfile(&config.CreateProfileParams{ProfileName: &[]string{"test"}[0]}) + _, err = client.Config.CreateProfile(&config.CreateProfileParams{ProfileName: &[]string{"docker"}[0]}) if err != nil { t.Logf("%s", err) } - assert.NoError(t, err) + assert.Error(t, err) _, err = client.Config.CreateSceneCollection( &config.CreateSceneCollectionParams{SceneCollectionName: &[]string{"test"}[0]}, ) @@ -89,11 +89,11 @@ func Test_config(t *testing.T) { t.Logf("%s", err) } assert.NoError(t, err) - _, err = client.Config.SetCurrentProfile(&config.SetCurrentProfileParams{ProfileName: &[]string{"test"}[0]}) + _, err = client.Config.SetCurrentProfile(&config.SetCurrentProfileParams{ProfileName: &[]string{"docker"}[0]}) if err != nil { t.Logf("%s", err) } - assert.Error(t, err) + assert.NoError(t, err) _, err = client.Config.SetCurrentSceneCollection( &config.SetCurrentSceneCollectionParams{SceneCollectionName: &[]string{"test"}[0]}, ) @@ -144,7 +144,7 @@ func Test_config(t *testing.T) { t.Logf("%s", err) } assert.NoError(t, err) - _, err = client.Config.RemoveProfile(&config.RemoveProfileParams{ProfileName: &[]string{"test"}[0]}) + _, err = client.Config.RemoveProfile(&config.RemoveProfileParams{ProfileName: &[]string{"docker"}[0]}) if err != nil { t.Logf("%s", err) } From 80f71f9c19a9e9af6f2bb7f7e8b70efbea177498 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:35:00 -0400 Subject: [PATCH 19/20] go 1.23 --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 275b6ae..d71daca 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/andreykaipov/goobs -go 1.22 +go 1.23 require ( github.com/buger/jsonparser v1.1.1 From 48ece21d00bee059a781bc268db02c30c612b194 Mon Sep 17 00:00:00 2001 From: Andrey Kaipov Date: Thu, 24 Oct 2024 02:35:29 -0400 Subject: [PATCH 20/20] yeah --- .github/workflows/ci.yml | 2 +- script/test.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2a494ed..7a83a0d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -51,7 +51,7 @@ jobs: go-version-file: go.mod - name: make test run: | - # make test.unit + make test.unit # some tests are flaky because it's running against a dockerized obs # instance, so just retry a few times or whatever to be certain for _ in $(seq 1 5); do diff --git a/script/test.sh b/script/test.sh index 168067b..87c241f 100755 --- a/script/test.sh +++ b/script/test.sh @@ -47,8 +47,8 @@ main() { # note: `scenes` and `transitions` must be ran after `ui` # - # (client|client_repeat|get_raw_response|multi_goroutine|profile) categories=' + (client|client_repeat|get_raw_response|multi_goroutine|profile) config filters general