Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make_standalone_toolchain.py produces broken gcc wrapper scripts #803

Closed
abustany opened this issue Oct 2, 2018 · 1 comment
Closed

make_standalone_toolchain.py produces broken gcc wrapper scripts #803

abustany opened this issue Oct 2, 2018 · 1 comment
Assignees
@DanAlbert
Labels
standalone-toolchain
Milestone
r18b

Comments

@abustany
Copy link

abustany commented Oct 2, 2018

Description

It seems that GCC binaries are now stubbed by shell scripts that invoke Clang instead. The way the Clang binary is located breaks when those binaries are copied out of the NDK tree by make_standalone_toolchain.py.

Test case:

  1. /place/to/android-ndk-r18/build/tools/make_standalone_toolchain.py --api 27 --arch arm64 --install-dir arm64
  2. ./arm64/bin/aarch64-linux-android-gcc

This prints en error because the clang binary cannot be found.

Environment Details

Not all of these will be relevant to every bug, but please provide as much
information as you can.

  • NDK Version: 18.0.5002713
  • Build system: none
  • Host OS: Linux 4.18.9-200.fc28.x86_64
  • Compiler: Clang via GCC stubs
  • ABI: arm64
@enh enh changed the title make_standalone_toolchain.py produces broken binaries make_standalone_toolchain.py produces gcc wrapper scripts Oct 2, 2018
@enh enh changed the title make_standalone_toolchain.py produces gcc wrapper scripts make_standalone_toolchain.py produces broken gcc wrapper scripts Oct 2, 2018
@DanAlbert DanAlbert self-assigned this Oct 2, 2018
@DanAlbert DanAlbert added this to the r18b milestone Oct 2, 2018
@DanAlbert
Copy link
Member

https://android-review.googlesource.com/c/platform/ndk/+/778917

scyclzy pushed a commit to scyclzy/ndk that referenced this issue Oct 20, 2018
@DanAlbert
Fixup GCC wrappers in make_standalone_toolchain.py.
7214adf 
Test: make_standalone_toolchain.py --arch arm --install-dir foo && \
           cat foo/bin/arm-linux-androideabi-gcc &&
           foo/bin/arm-linux-androideabi-gcc -c foo.c
Bug: android/ndk#803

Change-Id: Ib6b223e54dd237623b837ea72ef7978d1e9b7d2a
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
@DanAlbert
Update git submodules
398b313 
* Update ndk from branch 'ndk-release-r18'
  to 21b4e70bd28c38762f3da05862b406dab1096449
  - Merge "Fixup GCC wrappers in make_standalone_toolchain.py." into ndk-release-r18
  - Fixup GCC wrappers in make_standalone_toolchain.py.
    
    Test: make_standalone_toolchain.py --arch arm --install-dir foo && \
               cat foo/bin/arm-linux-androideabi-gcc &&
               foo/bin/arm-linux-androideabi-gcc -c foo.c
    Bug: android/ndk#803
    
    Change-Id: Ib6b223e54dd237623b837ea72ef7978d1e9b7d2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
standalone-toolchain
Projects
None yet
Milestone
r18b
Development

No branches or pull requests
2 participants
@DanAlbert @abustany