Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ANDROID_USE_LEGACY_TOOLCHAIN_FILE is not obeyed in try-compile #1573

Closed
DanAlbert opened this issue Aug 26, 2021 · 2 comments
Closed

[BUG] ANDROID_USE_LEGACY_TOOLCHAIN_FILE is not obeyed in try-compile #1573

DanAlbert opened this issue Aug 26, 2021 · 2 comments
Assignees
@DanAlbert
Labels
bug

Comments

@DanAlbert
Copy link
Member

https://cs.android.com/android/platform/superproject/+/master-ndk:ndk/build/cmake/android.toolchain.cmake;l=255-268;drc=5bb349589cd7114b6adad1d830a4ca1a10472935 is a list of variables to be preserved for try-compile uses of the toolchain file. We didn't persist the ANDROID_USE_LEGACY_TOOLCHAIN_FILE value here so try-compile will only ever use the default behavior.

I already have the fix for this, just filing for visibility.
@DanAlbert DanAlbert added the bug label Aug 26, 2021
@DanAlbert DanAlbert self-assigned this Aug 26, 2021
@rprichard
Copy link
Collaborator

This was fixed by https://android-review.googlesource.com/c/platform/ndk/+/1810691/.

@rprichard
Copy link
Collaborator

Fixed in r23b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanAlbert @rprichard