Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta bug: lift required arguments into the clang driver #812

Closed
7 tasks done
DanAlbert opened this issue Oct 10, 2018 · 3 comments
Closed
7 tasks done

meta bug: lift required arguments into the clang driver #812

DanAlbert opened this issue Oct 10, 2018 · 3 comments
Labels
Milestone

Comments

@DanAlbert
Copy link
Member

DanAlbert commented Oct 10, 2018

There are a handful of arguments that must be passed to Clang to compile for Android that ought to be handled by Clang itself. This bug tracks enumerating those and tracking the individual bugs for each.

Required, your code will not work without these (at least in some situations):

Technically required, but will not result in an error if not used because the linker assumes it to be true:

And finally,

  • Update Clang to pull in the above patches.

Moved to r21:

@pirama-arumuga-nainar
Copy link
Collaborator

Note that during LTO, assembly happens during linking; -Wa,--no-exec-stack should be passed to the linker plugin as well.

@DanAlbert
Copy link
Member Author

I think that should be handled by the change I uploaded to lift this into the driver, but should definitely check.

@pirama-arumuga-nainar
Copy link
Collaborator

Aah, sorry I brought it up here. LTO + -Wa,--no-exec-stack is currently broken and needs to be fixed - the -mnoexecstack doesn't get passed to the backend because LTO creates a new backend during linking. That's orthogonal to what you're doing here. I'll file an internal bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants