-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly builds with baseline profiles #1173
Conversation
dcb23c1
to
81956f4
Compare
RFR. @JoseAlcerreca & @dturner PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally ok with this, but it would be nice if Don/Jose took a look as they maintain the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started the review assuming this nightly was only for BP generation and only realized you were creating a full nightly. I think the main
build should be our SOT for status, so just make this one about BP.
Combined test coverage report
|
Combined test coverage report
|
f770711
to
c35b1e4
Compare
Combined test coverage report
|
@JoseAlcerreca could this be a flaky test?
If so, could you show me how to fix it or approve the PR so it can be merged? |
Let's merge #1395 first and make sure this one passes |
SGTM |
c35b1e4
to
aca83e4
Compare
Combined test coverage report
|
Combined test coverage report
|
3 similar comments
Combined test coverage report
|
Combined test coverage report
|
Combined test coverage report
|
19d0f7d
to
e734182
Compare
Combined test coverage report
|
341f4af
to
3e1fc60
Compare
Combined test coverage report
|
Change-Id: I85f431fa4ceb73be87cba997eb8808961d4197cd
Change-Id: I79d0cfd8e7002b5c526fd3cf10867b0cd40a99eb
Change-Id: Ib6cbe7d9a69b51490aa36dc45d04faa2d141c9ab
Change-Id: I4eda2fc52a3ddcae026fbae57b0299bb539abeff
Change-Id: I112cb9b7a16a7c8b25751d226ce93cb69cd9cdcb
Change-Id: I605e220d073ea25638a19dcca4e682e68606eda5
Change-Id: I1c5ea67943f20c6f42ee46a76d4787013c247b95
Change-Id: Ibf64e73238d660772757c01b7d1595e0aa9bc8a4
b/287312019 Change-Id: I3c89605e1707ac25d3726e37e9254085cd698191
58888d3
to
7b10f00
Compare
Combined test coverage report
|
Change-Id: Ief864552cde2fd2969c56e57974bb8e403d229a7
Combined test coverage report
|
Change-Id: Id7903de5b5f79c150a514ea186630d4f85f1b268
Combined test coverage report
|
Change-Id: I50a03a73fd3f35260d4635e7fa7ff80144aa4ead
Combined test coverage report
|
Combined test coverage report
|
Added custom metrics to better understand how effecetive a baseline profile is. These TraceSectionMetrics keep track of JIT compilations as well as class initializations which should go down when a BP is properly applied to the app. Change-Id: Idd1044bdccc3cbaf64aba8d7a909c4d150f82341
f202fb1
to
bc0c7e4
Compare
Combined test coverage report
|
It seems that not enabling the KVM before setting up GMD causes this problem. https://github.com/android/nowinandroid/actions/runs/10953338005/job/30413441493
|
@lihenggui the issue was caused by GMD requiring a lot more processing power than what the GitHub runners offer in the free tier. So the relevant step is this one
Which has to be executed before the entire build is kicked off. |
Change-Id: I162cd9eca724c30d839add912359482cbce7c68e
Thanks for submitting a pull request. Please include the following information.
What I have done and why
Enabled baseline profile generation for new nightly build type.
With KVM, GMD run smoothly and BP generation is not negatively affected any longer.
Enabling nightly builds for this keeps PR builds fast while allowing for baseline profiles to be generated regularly as well.
Enabled Startup Profiles for smaller classes.dex and faster app startup
Fixes #<issue_number_goes_here>
Do tests pass?
DemoDebug
variant:./gradlew testDemoDebug
./gradlew --init-script gradle/init.gradle.kts spotlessApply