Rename Fake to Demo #1291
Merged
Rename Fake to Demo #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I5b1d7963e623832a766900aa74ef1085aac0cacc
Change-Id: Icd7005ec38495a1a4bc6f1594f70a2c1228538ab
Change-Id: I48bb3c26ef02d6302cb7caabcaa17d5b4659031a
This reverts commit a5be299.
Change-Id: I3b1e19dedd238ec96bd8debee5fcbcc91bc25094
Change-Id: Ife321dd95238227bfdfc1f13f6832472bd699b6f
Change-Id: I025fc00aab56c998c64bd88ad337cba8061d507c
|
You make an excellent point. I agree, "Demo" is more accurate than "Fake". Thanks. |
dturner
approved these changes
Mar 21, 2024
Jaehwa-Noh
added a commit
to Jaehwa-Noh/Jaehwa-Noh
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
Rename Fake to Demo.
When name is Fake, it is make analysis hard. The problem is naming.
Actually it is not fake because it is for demo to build on not product code.
The only
NiaNetworkDataSourcereference isFakeNiaNetworkDataSourcein non-production build.So, I think it is better to rename Fake to Demo.