Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Retrofit 2.11.0 #1623

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Update to Retrofit 2.11.0 #1623

merged 2 commits into from
Sep 25, 2024

Conversation

dturner
Copy link
Collaborator

@dturner dturner commented Sep 20, 2024

See #1548. Thanks to @SimonMarquis for doing this.

- Replace Jake Wharton's Kotlinx Serialization converter with new retrofit's `converter-kotlinx-serialization`.
- Remove custom Proguard rules that are now part of the dependency: https://github.com/square/retrofit/tree/trunk/retrofit-response-type-keeper#readme

Changelog: https://github.com/square/retrofit/blob/trunk/CHANGELOG.md
Copy link

Combined test coverage report

Overall Project 42.36% 🍏
Module Coverage
network 38.37% 🍏
Files
Module File Coverage
network RetrofitNiaNetwork.kt 0% 🍏

@dturner dturner merged commit 573cf2d into main Sep 25, 2024
4 checks passed
@dturner dturner deleted the retrofit-2.11.0 branch September 25, 2024 16:29
@@ -48,7 +48,7 @@ moduleGraph = "2.5.0"
okhttp = "4.12.0"
protobuf = "4.26.1"
protobufPlugin = "0.9.4"
retrofit = "2.9.0"
retrofit = "2.11.0"
retrofitKotlinxSerializationJson = "1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line could be removed since it is not in use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants