From 7a5ed9a67667df1717508572a54e4faf376bb9fa Mon Sep 17 00:00:00 2001
From: Sahil Khan <85223122+sahilsk3333@users.noreply.github.com>
Date: Thu, 16 Nov 2023 18:29:05 +0530
Subject: [PATCH] Separate navigation route and args Issue#863

---
 .../apps/sunflower/compose/SunflowerApp.kt    | 31 ++++++++-------
 .../apps/sunflower/utilities/Screen.kt        | 39 +++++++++++++++++++
 2 files changed, 56 insertions(+), 14 deletions(-)
 create mode 100644 app/src/main/java/com/google/samples/apps/sunflower/utilities/Screen.kt

diff --git a/app/src/main/java/com/google/samples/apps/sunflower/compose/SunflowerApp.kt b/app/src/main/java/com/google/samples/apps/sunflower/compose/SunflowerApp.kt
index f59541972..e04437861 100644
--- a/app/src/main/java/com/google/samples/apps/sunflower/compose/SunflowerApp.kt
+++ b/app/src/main/java/com/google/samples/apps/sunflower/compose/SunflowerApp.kt
@@ -23,15 +23,14 @@ import androidx.compose.runtime.Composable
 import androidx.compose.ui.platform.LocalContext
 import androidx.core.app.ShareCompat
 import androidx.navigation.NavHostController
-import androidx.navigation.NavType
 import androidx.navigation.compose.NavHost
 import androidx.navigation.compose.composable
 import androidx.navigation.compose.rememberNavController
-import androidx.navigation.navArgument
 import com.google.samples.apps.sunflower.R
 import com.google.samples.apps.sunflower.compose.gallery.GalleryScreen
 import com.google.samples.apps.sunflower.compose.home.HomeScreen
 import com.google.samples.apps.sunflower.compose.plantdetail.PlantDetailsScreen
+import com.google.samples.apps.sunflower.utilities.Screen
 
 @Composable
 fun SunflowerApp() {
@@ -46,19 +45,21 @@ fun SunFlowerNavHost(
     navController: NavHostController
 ) {
     val activity = (LocalContext.current as Activity)
-    NavHost(navController = navController, startDestination = "home") {
-        composable("home") {
+    NavHost(navController = navController, startDestination = Screen.Home.route) {
+        composable(route = Screen.Home.route) {
             HomeScreen(
                 onPlantClick = {
-                    navController.navigate("plantDetail/${it.plantId}")
+                    navController.navigate(
+                        Screen.PlantDetail.passPlantId(
+                            plantId = it.plantId
+                        )
+                    )
                 }
             )
         }
         composable(
-            "plantDetail/{plantId}",
-            arguments = listOf(navArgument("plantId") {
-                type = NavType.StringType
-            })
+            route = Screen.PlantDetail.route,
+            arguments = Screen.PlantDetail.arguments
         ) {
             PlantDetailsScreen(
                 onBackClick = { navController.navigateUp() },
@@ -66,15 +67,17 @@ fun SunFlowerNavHost(
                     createShareIntent(activity, it)
                 },
                 onGalleryClick = {
-                    navController.navigate("gallery/${it.name}")
+                    navController.navigate(
+                        Screen.Gallery.passPlantName(
+                            plantName = it.name
+                        )
+                    )
                 }
             )
         }
         composable(
-            "gallery/{plantName}",
-            arguments = listOf(navArgument("plantName") {
-                type = NavType.StringType
-            })
+            route = Screen.Gallery.route,
+            arguments = Screen.Gallery.arguments
         ) {
             GalleryScreen(
                 onPhotoClick = {
diff --git a/app/src/main/java/com/google/samples/apps/sunflower/utilities/Screen.kt b/app/src/main/java/com/google/samples/apps/sunflower/utilities/Screen.kt
new file mode 100644
index 000000000..392da4961
--- /dev/null
+++ b/app/src/main/java/com/google/samples/apps/sunflower/utilities/Screen.kt
@@ -0,0 +1,39 @@
+/*
+ * Copyright 2023 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.google.samples.apps.sunflower.utilities
+
+import androidx.navigation.NavType
+import androidx.navigation.navArgument
+
+sealed class Screen(val route: String) {
+    data object Home : Screen("home")
+    data object PlantDetail : Screen("plantDetail/{plantId}") {
+        fun passPlantId(plantId: String) = "plantDetail/${plantId}"
+        val arguments = listOf(navArgument("plantId") {
+            type = NavType.StringType
+        })
+
+    }
+
+    data object Gallery : Screen("gallery/{plantName}") {
+        fun passPlantName(plantName: String) = "gallery/${plantName}"
+        val arguments = listOf(navArgument("plantName") {
+            type = NavType.StringType
+        })
+
+    }
+}
\ No newline at end of file