This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Feature pull to refresh gallery screen issue [866] #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahilsk3333
changed the title
arriolac
suggested changes
Dec 7, 2023
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/GalleryViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/compose/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/GalleryViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/GalleryViewModel.kt
Outdated
Show resolved
Hide resolved
arriolac
suggested changes
Dec 20, 2023
| val photo = pagingItems[index] | ||
| "${ photo?.id ?: ""}${index}" | ||
|
|
||
| var isRefreshing by remember { mutableStateOf(false) } |
There was a problem hiding this comment.
Extra isRefreshing state is not needed. pullToRefreshState should be the source of truth instead of having 2 different "is refreshing" states.
app/src/main/java/com/google/samples/apps/sunflower/compose/gallery/GalleryScreen.kt
Outdated
Show resolved
Hide resolved
| if (pullToRefreshState.isRefreshing){ | ||
| LaunchedEffect(Unit){ | ||
| onPullToRefresh() | ||
| isRefreshing = true |
There was a problem hiding this comment.
Remove this per comment above
| when (pagingItems.loadState.refresh) { | ||
| is LoadState.Loading -> Unit | ||
| is LoadState.Error,is LoadState.NotLoading -> { | ||
| isRefreshing = false |
There was a problem hiding this comment.
You can call pullToRefreshState.endRefresh() directly here
| isRefreshing = true | ||
| } | ||
| } | ||
| LaunchedEffect(isRefreshing){ |
There was a problem hiding this comment.
This block of code is not needed
app/src/main/java/com/google/samples/apps/sunflower/viewmodels/GalleryViewModel.kt
Show resolved
Hide resolved
|
Looks like the build failed due to a merge conflict. If you can address that on your side I'll go ahead and merge this in. Thanks! |
…_866 # Conflicts: # app/src/main/java/com/google/samples/apps/sunflower/compose/gallery/GalleryScreen.kt # app/src/main/java/com/google/samples/apps/sunflower/compose/home/HomeScreen.kt
…screen_issue_866' into feature_pull_to_refresh_gallery_screen_issue_866 # Conflicts: # app/src/main/java/com/google/samples/apps/sunflower/compose/home/HomeScreen.kt
Sure i will look into this, Thanks! |
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Pull to refresh for gallery screen #866
updated material3 version to "1.2.0-alpha11"