Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom actions in PlayerControlView #231

Open
maknon opened this issue Dec 19, 2022 · 1 comment
Open

Support for custom actions in PlayerControlView #231

maknon opened this issue Dec 19, 2022 · 1 comment

Comments

@maknon
Copy link

maknon commented Dec 19, 2022

Thank you for the new media3, such abstraction solves a lot of issues and makes the API more natural

i have implemented custom command as per #38 which reflected nicely in the notification. on the other hand, i cannot see it reflected in the PlayerControlView.

is there a way to do this.

i have implemented a workaround to utalise one of the buttons (seek to next) by overriding the exo_next view (action and drawable) but this is not a clean way.

@icbaker
Copy link
Collaborator

icbaker commented Jan 25, 2023

The UI components currently only use the Player interface and other components from lib-common. They have no awareness of anything that's specific to lib-session (such as custom commands).

I will keep this open as a potential enhancement, but we have to plans to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants