Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should a .nojekyll file be generated by default? #160

Closed
Marv51 opened this issue Dec 13, 2022 · 2 comments
Closed

Should a .nojekyll file be generated by default? #160

Marv51 opened this issue Dec 13, 2022 · 2 comments
Labels
feature this issue requests a new feature

Comments

@Marv51
Copy link

Marv51 commented Dec 13, 2022

I ran into some issues with GitHub Pages a while ago where my already finished project was changed again by GitHub Pages, because it was compiled again with Jekyll (result: .txt assets are just missing)

The solution was simple enough: Just add a .nojekyll file to the root of the output.

I am only starting out with angular-cli-ghpages, but I do believe putting that file would be a good idea. I put it always when the uploaded content is not meant to be compiled (again) with Jekyll, which should be every angular project.


From the GitHub Pages documentation:

If you publish your site from a source branch, GitHub Pages will use Jekyll to build your site by default. If you want to use a static site generator other than Jekyll, we recommend that you write a GitHub Actions to build and publish your site instead. Otherwise, disable the Jekyll build process by creating an empty file called .nojekyll in the root of your publishing source, then follow your static site generator's instructions to build your site locally.

@JohannesHoppe
Copy link
Member

JohannesHoppe commented Dec 13, 2022

I agree, this could be a useful feature. We have mentioned the .nojekyll file once in the readme. But it could be useful to include it by default.

@JohannesHoppe JohannesHoppe added the feature this issue requests a new feature label Dec 13, 2022
@JohannesHoppe
Copy link
Member

JohannesHoppe commented Jan 26, 2024

Added in angular-cli-ghpages@2.0.0-beta.1. Please try out this version and give me feedback. A .nojekyll file is created by default now.

See #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature this issue requests a new feature
Projects
None yet
Development

No branches or pull requests

2 participants